search

bobosch / ods_osm

TYPO3 Extension OpenStreetMap
10 stars 22 forks source link

Broken Icon URL #88

Closed ut closed 2 years ago

ut commented 2 years ago

In the Leaflet section it seems that an icon URL returns (at my installation) an incorrect URL. This icon is used in the control layers

image

In the source code the icon URL is shown with the double path part "Core"

image

The parts where this URL is build are in Classes/Provider/Leaflet.php

Line 31 https://github.com/bobosch/ods_osm/blob/abad6f4b0f7097170ac732932b8d903cd9c031fa/Classes/Provider/Leaflet.php#L31

and then in line 269

https://github.com/bobosch/ods_osm/blob/abad6f4b0f7097170ac732932b8d903cd9c031fa/Classes/Provider/Leaflet.php#L269

Extension version is 4.0.0 in a Typo3 v10 installation.

If someone can confirm this issue I'd be happy to make a PR.

Besides, thanks @bobosch and contributors for this awesome extension!

albig commented 2 years ago

Thank you for reporting. This is good analyzed and I pretty sure, the path component Core/ is pretty stupid in line 269.

https://github.com/bobosch/ods_osm/blob/abad6f4b0f7097170ac732932b8d903cd9c031fa/Classes/Provider/Leaflet.php#L269

Your're welcome to provide a pull request!

ut commented 2 years ago

Thanks for the response. I checked also, if this works either way, if local JS is loaded or via CDN