search

bobscodedump / pe

0 stars 0 forks source link

Spaces not working correctly with find #15

Open bobscodedump opened 11 months ago

bobscodedump commented 11 months ago

Screenshot 2023-11-17 at 5.01.35 PM.png

In this case, finding "a " results in entries like David Li, where there is no "a" character followed by a space.

soc-pe-bot commented 11 months ago

Team's Response

Duplicate of #3624, where spaces in quoted strings aren't searched for when they are at the start or end of the quoted string, which is expected behaviour in quoted strings in other applications

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Nothing happens when trying to find n/" "

image.png

To reproduce:

  1. find n/" "

Expected: All contacts with a space in their name will be displayed. Actual: Nothing happens. No error message displayed.

If a user wishes to search for contacts who have names consisting of 2 words, they are unable to do so.

[original: nus-cs2103-AY2324S1/pe-interim#2821] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Summary of the bug is that if there are spaces at the start or end of the quoted string search term, they are stripped from the search term.

I agree with this as reported, since this is behaviour I'd expect to see in other applications that support quoted-string finding, and I did not consider this when designing the feature, and it does not fail gracefully / is not in planned enhancement, and it's also rare but not impossible that a user will search for strings starting or ending with a space

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]