search

bobtfish / puppet-ethtool

Set ethernet options from puppet
Apache License 2.0
4 stars 10 forks source link

Changing both speed and duplex doesn't converge in one run #9

Closed bobtfish closed 10 years ago

bobtfish commented 10 years ago

From @bretm in https://github.com/bobtfish/puppet-ethtool/issues/8

But if I change both the speed and duplex, it takes two puppet runs to apply both:

[root@havelock ~]# ethtool -s eth1 speed 10 duplex half
[root@havelock ~]# ethtool eth1 | egrep '(Speed|Duplex)'
Speed: 10Mb/s
Duplex: Half
[root@havelock ~]# puppet agent --test
Info: Retrieving pluginfacts
Info: Retrieving plugin
[snip]
Info: Applying configuration version '1403695136'
Notice: /Stage[main]/Discworld::Ethtool::Havelock/Ethtool[eth1]/speed: speed > changed '10' to '100'
Notice: /Stage[main]/Discworld::Ethtool::Havelock/Ethtool[eth1]/duplex: duplex changed 'half' to 'full'
Notice: Finished catalog run in 1.82 seconds
[root@havelock ~]# ethtool eth1 | egrep '(Speed|Duplex)'
Speed: 100Mb/s
Duplex: Half
[root@havelock ~]# puppet agent --test
Info: Retrieving pluginfacts
Info: Retrieving plugin
[snip]
Info: Applying configuration version '1403695136'
Notice: /Stage[main]/Discworld::Ethtool::Havelock/Ethtool[eth1]/duplex: duplex changed 'half' to 'full'
Notice: Finished catalog run in 1.76 seconds
[root@havelock ~]# ethtool eth1 | egrep '(Speed|Duplex)'
Speed: 100Mb/s
Duplex: Full
[root@havelock ~]#
bobtfish commented 10 years ago

Fixed in 807bf736