search

bobthecow / genghis

The single-file MongoDB admin app
http://genghisapp.com
MIT License
1.45k stars 164 forks source link

Feature/explain #121

Closed craigerm closed 11 years ago

craigerm commented 11 years ago

Hey there,

I've put together an explain feature for genghis (with tests). This is for issue #60.

Right now the the feature is available as a checkbox in the advanced search area. If you have a better idea for how to enable this in the UI let me know. I think in the advanced area is a good idea because it's out of the way.

I've included the php change too but it's been quite a while since I did any php work so it was pretty hacky.

Any feedback would be great!

bobthecow commented 11 years ago

Thanks for working on this!

I wonder if it would work better as a button than a checkbox, since "explain" feels more like a different thing you could do with the same form...

screen shot 2013-07-04 at 12 02 21 am

craigerm commented 11 years ago

No worries! It was something I was needing lately.

Good idea, that does look better. I wasn't sold on the checkbox - and changing it will clean up some of the view logic.

I'll make the change and let you know,

craigerm commented 11 years ago

I've changed it to be a button, which feels much more natural - and saves a click which is nice. It also cleans up some of the backbone views which is a nice benefit.

bobthecow commented 11 years ago

Hey, thanks for the updates. The button definitely works better.

Sorry about the delay. I decided it would be great to take it a step further and make it a first-class feature and API endpoint. I've merged this branch into develop, and added shuffled things around a bit to make room for it: bfc91e97cc723f1c9580710a68e44b4dd8d204da

Explain will be in the next release! Thanks again :)