bobthecow / genghis

The single-file MongoDB admin app
http://genghisapp.com
MIT License
1.45k stars 166 forks source link

Add docker image link #217

Open soullivaneuh opened 8 years ago

soullivaneuh commented 8 years ago

Hey there,

I just released a Docker image for your Genghis app: https://hub.docker.com/r/dockervan/genghis/

In contrary of other images, I want to sell a "ready to use" app with the tinier size as possible (actually less than 30 MB).

For the future, I want to manage multiple version tags.

If you are interested, you can accept this PR that add a short description of that on the README. :+1:

Regards.

soullivaneuh commented 8 years ago

I see the README file changed on develop branch. Should I do another PR for that?

pataquets commented 7 years ago

I've checked the image link and found that it is not an Automated Build (ie, based on source repo), so I imagine it is built locally and later pushed to DH.

I would favor an AB because it provides way much more trust, since the source git repo is connected to the DH build and uploaded image always comes from the source code build and it can be viewed publicly on Github.

I have an image, which I need to be trusted by others at https://hub.docker.com/r/pataquets/mongodb-genghis/ . However, it is not also a good approach to create an AB, since it is based on a base image of mine, which might suit or not others. Ideally, it shoud be based in an official PHP image and build from there by adding MongoDB PHP extension and later adding the source files.

soullivaneuh commented 7 years ago

I've checked the image link and found that it is not an Automated Build (ie, based on source repo)

Yes. The image is built on Travis but the build is repeated every day thanks to Travis cron.

it shoud be based in an official PHP image and build from there by adding MongoDB PHP

Genghis is Ruby first AFAIK even if it propose both.

This is why I choose official alpine image for light sizing.

But I saw Ruby image propose now an alpine variant: https://hub.docker.com/_/ruby/

I may try it and do an AB at the same time.