search

bobthekingofegypt / dagre-reactjs

React component for rendering a dagre graph layout without any dependency on d3
MIT License
28 stars 8 forks source link

DagreReact component requires graphLayoutStarted #13

Closed andrico1234 closed 3 years ago

andrico1234 commented 3 years ago

Hey! thanks so much for this library. I was actually shown this by @Layvier , and I'm looking to refactor beautiful skill tree to use something like this to handle the rendering to the DOM.

I'm getting started withthe alpha and noticed that in the readme no other props aside from the edges and nodes are required to please the DagreReact. I'm not sure if this is intentional but i'm required to pass through graphLayoutStarted. It seems all of the other props have default values except this one. If this isn't intentional, i can whip up a super quick PR.

bobthekingofegypt commented 3 years ago

Hello,

Sorry about that, sounds like an oversight from the split of DagReact from DagreReact. If you have time a pull request would be welcome, if not I'll be back at the computer later tonight.

I'm surprised npm puts people onto the alpha, I wasn't expecting that. Please bear in mind the alpha is for experimenting with different graph layout libraries and may change things.

bobthekingofegypt commented 3 years ago

Thanks for the fix.

Cheers Bob