bobtheuberfish / chiriboga

Implements Netrunner in Javascript against an AI opponent
https://chiriboga.sifnt.net.au/
GNU General Public License v3.0
86 stars 11 forks source link

Update systemupdate2021.js to fix Ice Wall AI #137

Closed jsfuchs closed 1 year ago

jsfuchs commented 1 year ago

Corp doesn't rez ice Wall since there is an ice wall in the server. To keep consistent with the logic in the comment, count the ice in the server instead to make sure there's stricly more than one (instead of at least 1).

bobtheuberfish commented 1 year ago

Thank you for this contribution. I am away on holiday at the moment but will check this when I return. I particularly want to test behaviour with installing vs rezzing since the original code is correct for installation as far as I can tell.

bobtheuberfish commented 1 year ago

Thanks for finding this. I've now fixed this in /dev by distinguishing whether the check is for rezzing or installing.

bobtheuberfish commented 1 year ago

I thought you would like to know that I am joining another in-progress Netrunner project. I will still maintain Chiriboga in terms of handling issues and fixing bugs but I don't intend to add new cards. This other project does not have AI yet but it has many many cards implemented and the lead developer is someone with professional experience so it has better long-term potential. If you are interested in being involved I'm sure your contributions would be appreciated, just let me know.

jsfuchs commented 1 year ago

Neat - I'm usually fairly busy (and coding is my day job so I'm less inclined to do it off-hours), but I'd be interested in seeing what's up. Send me a link or an email I can hit up - thanks!

bobtheuberfish commented 1 year ago

The best way to get in touch is via Discord. Otherwise this thread is currently my only way of replying to you but if you connect to the Green Level Clearance server you will be able to find me as bobthefish.

On Tue, 18 July 2023, 6:37 am Jared Fuchs, @.***> wrote:

Neat - I'm usually fairly busy (and coding is my day job so I'm less inclined to do it off-hours), but I'd be interested in seeing what's up. Send me a link or an email I can hit up - thanks!

— Reply to this email directly, view it on GitHub https://github.com/bobtheuberfish/chiriboga/pull/137#issuecomment-1638882668, or unsubscribe https://github.com/notifications/unsubscribe-auth/AU2G22TJ3HO5SRGFZ4IEIV3XQWSQBANCNFSM6AAAAAAXH4JIAE . You are receiving this because you modified the open/close state.Message ID: @.***>