bobtheuberfish / chiriboga

Implements Netrunner in Javascript against an AI opponent
https://chiriboga.sifnt.net.au/
GNU General Public License v3.0
86 stars 11 forks source link

Issue adding card "The Maker’s Eye" #160

Closed NyarlathotepZERO closed 3 months ago

NyarlathotepZERO commented 3 months ago

I tried pasting "The Maker’s Eye" text into a custom runner deck, though it would not recognize the card from this text, nor would it recognize it if there was a number placed in front of it.

If I began to type the word "the", "The Maker's Eye" card was suggested and was able to be added correctly. It's a strange issue and I'm not sure exactly why it would recognize one and not the other. I hope I have sufficiently explained it.

For the record the deck/text was copied from a NetrunnerDB jinteki.net export and all the other cards in the deck displayed correctly, not sure if this would change anything.

Some screenshots are attached to help explain the issue:

Screenshot 2024-05-26 110300 Screenshot 2024-05-26 110241 Screenshot 2024-05-26 110230

edit: As a further note, if I remove the text from the past char by char, it seems to be having an issue with the apostrophe, and once removed it suggests the correct card as expected.

Some further research and it seems the issue may be the difference in unicode char used between the 2: U+2019 : RIGHT SINGLE QUOTATION MARK {single comma quotation mark} (NetrunnerDB) U+0027 : APOSTROPHE {single quote; APL quote} (Chiriboga)

I'll leave this here for you anyway; to fix and/or close as you see fit.

bobtheuberfish commented 3 months ago

Thanks for reporting this. Only 12 characters of code to fix!