search

bobuhiro11 / gokvm

KVM based tiny x86 hypervisor written in pure golang, which can boot Linux
https://blog.bobuhiro11.net/tags/gokvm.html
MIT License
210 stars 24 forks source link

probe: Move files from tools package into probe. #129

Closed bobuhiro11 closed 1 year ago

bobuhiro11 commented 1 year ago

"tools" has no particular meaning, so I move the files into an easy-to-understand package called "probe".

ChriMarMe commented 1 year ago

Maybe "util" would be a viable name as well as a place for general utility functions.

bobuhiro11 commented 1 year ago

Thanks for the comment! But since this is a specialized feature and not a generic one, I think it would be better to give it some name such as "probe". I wish I had suitable words, but my vocabulary is poor...

https://go.dev/blog/package-names

Avoid meaningless package names. Packages named util, common, or misc provide clients with no sense of what the package contains. This makes it harder for clients to use the package and makes it harder for maintainers to keep the package focused.

ChriMarMe commented 1 year ago

Oh, I see. I sometimes forget about those best practices.