Closed ChriMarMe closed 1 year ago
This is much more convenient than using FlagSets and implementing all the support for the same functionality.
Last thing I need to move the Config struct to vmm and hopefully be done with it.
fails because coverage goes down by 3 %. Will fix tomorrow
-5% test coverage. no idea how to cope with it....
I placed the untestable code of kong (like the run functions of the command structs) into seperate file and made sure it is excluded from coverage until we find a better solution.
Coverage still under 82%. Dunno if i ever reach it again.
81%.....
If we can test that the proposal in this PR is working as expected in the CI, then we don't need to be concerned about the value of coverage itself 😄
Wrote seperate tests for start and debug command parsing.
Well....i hope it works now as intended.
bad response status from coveralls: 500
{"message":"Build processing error.","error":true,"url":""}
idk
https://app.travis-ci.com/github/bobuhiro11/gokvm/jobs/608550126 says The command "sudo -E env "PATH=$PATH" go mod tidy && git diff --no-patch --exit-code go.sum" exited with 1.
.
go mod tidy
command would fix the CI.
Finally. Thanks for the hint to go mod tidy
Reopen for review. will rebase on main and adapt accordingly.