Closed jeremysimmons closed 8 years ago
Yes! A PR is very much appreciated.
Ditto
epic fail. I can't believe I never took you up on the offer for this @FrozenCow
@jeremysimmons No problem, PRs are appreviated any and all times! ;)
I've just updated the project a bit to work correctly with VS2015. I've also removed the original References directory and used nuget to retrieve external dependencies (zip/7zip dependencies). That should make things a bit nicer.
I have little experience (none to be exact) with publishing Nuget packages to nuget.org, but I could give it a go. Let me know if you want to package it or if you have any suggestions for packaging?
I’ll try creating a PR for creating nuget packages. Some of my thoughts on this:
Please be sure to stick to semver as it is an accepted best practice. Each release has to have a new version to be accepted by the nuget website. When coming up with a version number for a new release, apply the first matching rule:
For example, if you add a new member to the IFileSystem
interface (which would break any existing libraries which provide IFileSystem
implementations), this would match the first rule. If your current nuget version number is 1.2.3
, you’d bump MAJOR and reset MINOR and PATCH resulting in 2.0.0
. But if you were just fixing a bug that people are unlikely to encounter, you would hit the last rule and end up with version 1.2.4
as your next nuget version.
AssemblyVersion
unless you have a very good reason to. Nobody wants to deal with updating their references. Instead people use nuget itself to manage package versions. I think the only time it would make sense to update AssemblyVersion
would be if you bump the MAJOR and you want to support people who want to use both the old and new version of your assembly at the same time in a single program… which is not likely something anyone wants to support.IFileSystem
, PhysicalFileSystem
, and MemoryFileSystem
and not want the overhead of having 7-zip and its dependencies. You already put that archive support in a separate assembly because it is logically distinct from the core functionality provided by the SharpFileSystem
and it is an example of how others might provide extensions to SharpFileSystem
. So you will have 4 nuget packages: SharpFileSystem
, SharpFileSystem.Resources
, SharpFileSystem.SevenZip
, and SharpFileSystem.ZipLib
. And they will all be set up with dependencies on SharpFileSystem
as appropriate. Of course, SharpFileSystem.Tests
is meant for development of the sharpfilesystem project itself and shouldn’t become a nuget package.README.md
. This way you can endorse the packages as being official, making it much easier for developers to trust the packages and reduce the amount of time they waste on overhead/red tape type ;-). If you can create a nuget account matching your github user name that’d probably be good too ;-).I’ll try to write up a PR with proper .nuspec
s now… if I am ever unresponsive, I am on Twitter as ohnobinki and might be more responsive there ;-).
See #6
The project is now on Nuget. See https://www.nuget.org/packages?q=sharpfilesystem @binki's PR is used as the base for building the packages and AppVeyor is used to actually build and deploy the packages.
I'm interested in using this project, but would like a nuget package. would you accept a pull request for a nuget package?