feat: add support for timer and persistence to accept zoneddatetime and rubytime - Githubissues

boc-tothefuture / openhab-jruby

JRuby Libraries for Openhab

Eclipse Public License 2.0

6 stars 9 forks source link

feat: add support for timer and persistence to accept zoneddatetime and rubytime #565

Closed jimtng closed 2 years ago

jimtng commented 2 years ago

Add support for

after(ZonedDateTime.now.plus_minutes(xx)) (or create_timer)
after(Time.now + xx)
Item.persistence_method(Time.now - xxx)

I needed to use Item.historic_state from a specific date. ZonedDateTime is a bit onerous to use e.g.

start_date = ZonedDateTime.of(2021, 12, 23, 0, 0, 0, 0, ZoneId.system_default)
start_value = Item.historic_state(start_date)

With this PR I could use start_date = Time.new(2021, 12, 23).

boc-tothefuture commented 2 years ago

LGTM

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 4.36.0 :tada:

The release is available on:

4.36.0
GitHub release

Your semantic-release bot :package::rocket: