search

boc-tothefuture / openhab-jruby

JRuby Libraries for Openhab
Eclipse Public License 2.0
6 stars 9 forks source link

Remove duplicated monday from every.md #630

Closed m4rcu5 closed 1 year ago

m4rcu5 commented 1 year ago

Looks like the docs had two entries for :monday, one Monday ought to be enough for everyone.

ccutrer commented 1 year ago

Thanks. The commit message will need to be amended and then force-pushed to meet the guidelines (https://www.conventionalcommits.org/en/v1.0.0/ as described at https://boc-tothefuture.github.io/openhab-jruby/contributing/).

boc-tothefuture commented 1 year ago

@m4rcu5 Thanks for the PR! They are highly appreciated. As ccutrer mention in order for us to merge this we will need the commit message to be changed, because we automatically generate change lists from the commits and so we follow an open convention to do so. The build will fail if it isn't changed.

However, it is pretty easy to do so. git commit --amend -m "docs: Remove duplicated monday from every.md" and git push --force-with-lease

And you should be good to go.

Looking forward to more contributions!

jimtng commented 1 year ago

@boc-tothefuture I've always thought that the commit message doesn't like the description starting with a capital letter, i.e. it wants "docs: remove ....."

boc-tothefuture commented 1 year ago

@m4rcu5 let us know if you need any help making the update.

boc-tothefuture commented 1 year ago

Closing stale PR will fix with #657