Closed arebe closed 4 years ago
Fixed positioning perpetually assigns some of the viewport to the menu, but the menu may not be relevant during most of a working session. This seems suboptimal for an application where so much information has to be displayed concurrently.
There are various issues with how it's built today in terms of viewport - we've gotten feedback on this from various chapters and we want to prioritize it, as it creates a bad experience
That all sounds good to me, @susanpark! You may be interested in the changes in gh-22.
My question to Jesar was specifically about the way they intended the "schedule constraints" form to interact with the scroll bar. I'm seeking clarification because the design specification doesn't describe what's intended.
Currently, the patch affixes the form to the top of the Block's viewport such that it is present while the user scrolls through the shifts. An alternate interpretation would be to include the form as scrollable content (this would mean it would no longer be visible as the user moved through the shifts).
Here's a screen recording to demonstrate the two interpretations of the design specification:
Hello! Apologies for the delay in my response - based on how people were using it during the few test rounds, I think giving them as much space on the screen to plan is valuable. So after they set the constraints, they spend time dragging restaurants to hospitals. So I think we should allow the constraints and top of the page content to scroll away with the scrollbar. Thanks!
@jugglinmike thanks for the review -- I updated the PR with the scrolling UX you & Jesar suggested. think it's good to merge? also -- it looks like you all are using merge --squash
strategy, yeah?
Thanks @jesarshah! Thanks @arebe!
also -- it looks like you all are using
merge --squash
strategy, yeah?
Preferably, unless circumstances call for a merge commit
Closes #43
As per design v2: new
Constraints
UI: Move schedule and budget constraints to top of planning page, add new copy, add confirmation button.To create the
Confirm
button UX - I refactored theDndProvider
by moving it to wrap the top-levelChooser
component to resolve rendering / HTML5 Backend error.There's a new field in
Constraints
for max distance - while it appears in the UI, it's disabled until the distance calculation functionality build out.