search

bocoup / blocks-capacity-planner

An airtable block for matching supply to demand in an airtable base.
MIT License
3 stars 3 forks source link

#28 Updates names and adds descriptions #52

Closed shabbyjoon closed 4 years ago

jugglinmike commented 4 years ago

This is looking good, @shabbyjoon! There are just a couple things left, but since I was having trouble explaining them, I thought I'd make the changes and see what you think:

Do those changes look alright to you?

shabbyjoon commented 4 years ago

This is looking good, @shabbyjoon! There are just a couple things left, but since I was having trouble explaining them, I thought I'd make the changes and see what you think:

  • the HTML id attribute has to be unique for the whole page, so I've changed it to something different from each of the <p> tags
  • screen readers only recognize descriptions when they're declared with the aria-describedby attribute. I've added that to each <fieldset> element. Now, they each reference the new <p> tags, so screen readers will describe each set of form fields by reading the text in the paragraph
  • In JSX, the "single quote" character needs to be written with an HTML character code. I've replaced the two occurrences with &apos;

Do those changes look alright to you?

I'm sorry I missed this! They do and thank you for the explanation!

jugglinmike commented 4 years ago

Thanks for the patch!