search

bocoup / nest-weekly-review

An application for managing billing data for consulting projects
http://weekly-review.bocoup.com/
1 stars 2 forks source link

add support for initiatives #119

Closed tkellen closed 8 years ago

tkellen commented 8 years ago

Did some programming on my flight. This is in support of bocoup/api#286.

tkellen commented 8 years ago

@jugglinmike Would you have time to review this before EOD Friday?

jugglinmike commented 8 years ago

I can do this today, but not before EOD.

jugglinmike commented 8 years ago

@tkellen This looks good to me. I added a few extra assertions to back one of your changes.

I haven't been able to provision a virtual machine to functional test this because my machine is a little resource-starved at the moment. I can follow up with this on Monday, but if you'd like to land in advance of that, I'm willing to trust the integration tests as verification.

tkellen commented 8 years ago

Our Weekly Review meeting is at 4pm today. If you don't fully sign off by.... 1pm, I would like to land and deploy this. Seem good?

jugglinmike commented 8 years ago

Yup, that's fine.