search

bocoup / nest-weekly-review

An application for managing billing data for consulting projects
http://weekly-review.bocoup.com/
1 stars 2 forks source link

correctly persist leave_request_type_id when it is null #130

Closed tkellen closed 8 years ago

tkellen commented 8 years ago

closes gh-129

tkellen commented 8 years ago

I wish I understood more clearly why this works, but it works.

jugglinmike commented 8 years ago

I wish I understood more clearly why this works, but it works.

For Leave Request Types, null is an acceptable "new" value and should not prompt the UI to substitute the "old" (pre-editing) value.

jugglinmike commented 8 years ago

I added a test to prove this fix. Deploying shortly

jugglinmike commented 8 years ago

@tkellen The fix has been deployed. Can you confirm it is working as expected in production?

jugglinmike commented 8 years ago

Annoyed that the build is failing because TravisCI can no longer resolve the reference for the merge. Maybe annoyed enough to push an empty commit to master.

tkellen commented 8 years ago

Thanks @jugglinmike! This is working correctly now.