search

bocoup / nest-weekly-review

An application for managing billing data for consulting projects
http://weekly-review.bocoup.com/
1 stars 2 forks source link

Provisioning and deployment #24

Closed jugglinmike closed 9 years ago

jugglinmike commented 9 years ago

Hey @tkellen!

I did a comprehensive re-branding last night, and those changes were incompatible with the deployment corrects you made in gh-22. As we discussed on IRC, I've merged my own re-branding work (see aa6a38ce109) and rebased your pull request on top.

To help review, here's a diff of the two branches: https://gist.github.com/jugglinmike/bb7e3b0e8a3db7f5fb34

(That was generated running git diff HEAD~ upstream/provisioning-and-deployment deploy/.)

You'll note I've added an extra commit on top. This is a fix for the port problem you identified this morning. I thought it would make review easier to include it on top of your work (instead of into master, which would just add noise to the diff I shared above).

Mind giving this (the diff and my extra commit) a final once-over?

tkellen commented 9 years ago

Reading now!

tkellen commented 9 years ago

Note: I updated the DNS record from weeklyreview to weekly-review @ cloudflare.

tkellen commented 9 years ago

thoughts on adding vagrant exec to this project as well?

jugglinmike commented 9 years ago

thoughts on adding vagrant exec to this project as well?

I very much want to do that. My plan was to do it separately though

tkellen commented 9 years ago

Getting Unrecognized request origin. when attempting an oauth roundtrip after a fresh vagrant up.

jugglinmike commented 9 years ago

I did, too, until I deleted my cookies and re-tried.

tkellen commented 9 years ago

joy. trying again.