search

bocoup / nest-weekly-review

An application for managing billing data for consulting projects
http://weekly-review.bocoup.com/
1 stars 2 forks source link

allow choosing projects that have no phase in the review screen? #28

Closed tkellen closed 9 years ago

tkellen commented 9 years ago

Would this be possible @jugglinmike? For internal projects like Admiralty we could add a phase, but it would be nice if we could see them even if they didn't have one. Thoughts?

jugglinmike commented 9 years ago

It's certainly possible, but it might take some doing given that the UI and the application structure were designed around phases.

tkellen commented 9 years ago

Sorry, I was very imprecise in this request. What I meant to say is that it would be nice if active projects without a phase showed up in the dropdown for possible projects when you're reviewing a project that DOES have a phase. I wasn't suggesting they should appear on the main phase-selection area. Without this, it can be hard to make correcting entries since the thing you might need to correct to isn't shown.

I've added a two filters to the API for what I think would be required to make this happen, here bocoup/api#139 /projects?active=true&hasPhase=false

tkellen commented 9 years ago

I'm going to take a stab at a PR here shortly.

jugglinmike commented 9 years ago

True to his word, Tyler implemented this in gh-32