search

bocoup / nest-weekly-review

An application for managing billing data for consulting projects
http://weekly-review.bocoup.com/
1 stars 2 forks source link

Require manual invocation of `nest-cli` script #6

Closed jugglinmike closed 9 years ago

jugglinmike commented 9 years ago

This should not be included as an npm "post install" script because:

  1. In addition to initially installing dependencies, the npm install command is used to update dependencies. Secrets do not need to be fetched in these cases.
  2. Continuous integration services should be able to install dependencies in an automated fashion without the credentials required by the nest-cli script.

@Wilto sound good?

Wilto commented 9 years ago

Makes sense to me. +1’d, and merging.