search

bocoup / nest-weekly-review

An application for managing billing data for consulting projects
http://weekly-review.bocoup.com/
1 stars 2 forks source link

Can't Verify Internal Events #88

Closed MattSurabian closed 9 years ago

MattSurabian commented 9 years ago

When trying to verify anyone during Bocoupfest error received is:

Error: Cannot verify developer week.
A utilization must be set for every weekday before that week can be verified.

screenshot_2015-03-23_14-22-23

Test at this URL: http://weekly-review.bocoup.com/date/2015-03-08/phase/26/

MattSurabian commented 9 years ago

I suspect this is due to how Internal Events are treated?

jugglinmike commented 9 years ago

@MattSurabian I've deployed a fix for this. Would you mind verifying?

By the way: I appreciate you giving me the benefit of the doubt regarding the underlying cause. While I'd love to blame this bug on some complexity in the data model/business logic, the fact that these are internal events is a red herring. The issue was date math, plain and simple. The important detail was that the week in question contained a daylight savings time boundary. This has finally convinced me of the hubris of trying to do it myself, and you'll note that the fix introduces a dependency on the well-tested Moment.js library.

tkellen commented 9 years ago

This has been resolved.