search

bocoup / web-platform-contribution-guide

Source code for the Web Platform Contribution Guide, a guidebook to becoming a web platform contributor.
https://wpc.guide
13 stars 1 forks source link

Use CircleCI #57

Closed leobalter closed 4 years ago

leobalter commented 5 years ago

(testing in progress)

leobalter commented 5 years ago

the build part still shows here because of GH Actions, which we need to deactivate

zcorpan commented 4 years ago

I'm not familiar with CircleCI so can't tell if the config is correct, but it looks like it works! I'll deactivate GH Actions and merge. Thanks!

zcorpan commented 4 years ago

I rebased https://github.com/bocoup/web-platform-contribution-guide/pull/54 on latest master, which triggered the CircleCI checks as expected, but the PR is also waiting for the GH Actions 'build' check. Maybe it's because that was a required check when the PR was originally opened?

zcorpan commented 4 years ago

https://github.com/bocoup/web-platform-contribution-guide/pull/58 is a new PR, but it still expects a "build" check that doesn't complete. GitHub Actions was deactivated in Settings before merging this PR.

@leobalter can you have a look?