bodgit / memcardpro

Utility for 8BitMods MemCard PRO
https://8bitmods.com/accessories/memcard-pro/
BSD 3-Clause "New" or "Revised" License
38 stars 2 forks source link

Some games use different codes on the memory card vs game disc #3

Closed bodgit closed 1 year ago

bodgit commented 1 year ago

Based on https://github.com/emukidid/swiss-gc/blob/59218b94a16b3690e9a2e32426e2d4925f032e77/cube/swiss/source/nkit.c#L770-L773 F-Zero GX apparently reports its combined game and publisher code as GFZP01 yet my memory card shows the save data uses GFZP8P.

This means if I split the save data based on what the card reports, it can generate filenames that don't match what the MCP expects based on the game disc it booted. I expect the game itself to look on the memory card for the correct codes so it's literally just the filename that is wrong.

Minimal evidence suggests only F-Zero GX so far is affected. Fix should be to just maintain a static mapping table from memory card to disc; on a match use the replacement for any filenames.