search

bodgit / ntlmssp

Golang library implementing NTLM
https://godoc.org/github.com/bodgit/ntlmssp
BSD 3-Clause "New" or "Revised" License
13 stars 8 forks source link

make output of request to stdout optional #28

Closed CalypsoSys closed 1 year ago

CalypsoSys commented 1 year ago

Thank you so much for this great library - I plan on using it for winrm and ntlm encrypted messages

The following change is just to allow optional of request messages to the console

bodgit commented 1 year ago

I've just merged #29 which allows you to pass in a proper logging implementation to the HTTP client (based on logr), and I've replaced the two fmt.Println() calls with logging calls. The default implementation discards all logs so it should have the same effect as this PR but be a bit more flexible.

Those fmt.Println() calls should never really have been committed in the first place :wink:

I've no idea if the HTTP client actually works fully, I was trying to write one that didn't abuse the http.RoundTripper interface, which is frowned upon, but I don't think it's actually possible not to.

CalypsoSys commented 1 year ago

@bodgit - FYI the HTTP client works as I am currently using it for winrm calls see https://github.com/CalypsoSys/bobwinrmntlm for sample code