search

bodgit / puppet-carbon

Puppet Module for managing the Carbon daemons
https://forge.puppet.com/bodgit/carbon
Apache License 2.0
0 stars 4 forks source link

UDP configuration for relay template? #7

Open jcasals opened 4 years ago

jcasals commented 4 years ago

Hi,

First of all, thank you for your puppet modules. I am using carbon, memcached and graphite and they have been very easy to set up and have it working.

I had a manual installation based and had udp parameters for relay. I am sending data from a ganglia instance (we are migrating little by little) and I needed to have UDP configuration parameters in the relay section like this:

[relay]
ENABLE_UDP_LISTENER = True
UDP_RECEIVER_INTERFACE = 0.0.0.0
UDP_RECEIVER_PORT = 2013

But the templates doesn't have the option and there is no custom fragment possibility (I think). Do you plan to add this to the templates? Or do you recommend me to modify your module in our local installation?

Thank you!

bodgit commented 4 years ago

They're defined for the cache but not for the relay, (and I'm guessing the aggregator too), should be easy to fix.

jcasals commented 4 years ago

Hi,

I fixed in it in a fork. I can send a pull request in case you want it. Just fixed it in relay, but should be the same for aggregator.

Thanks for answering!

bodgit commented 4 years ago

If you have a fix, by all means send a PR. If you can also apply the same fix to the aggregator that would be great.