search

bodhiproject / qrypto

Qtum light wallet and local transaction signing client
GNU General Public License v3.0
9 stars 12 forks source link

add comment for testnet usd bal (Issue170) #184

Closed soshochang closed 6 years ago

soshochang commented 6 years ago

*add a comment (TestNet, no val) for USD bal on testnet, and corollary for regtest

@dwalintukan What do you think of how I am computing the networkName, and isMainNet, rather than passing the values over from the background? I think I recall your wanting to keep the stores dumber?, but I am also thinking that if we pass networkName and isMainNet from the bg, we will also have to re-update both with a new message whenever the network changes, and it is just a lot of extra message sending.

dwalintukan commented 6 years ago

@soshochang No issue with the computed values for the names. The only thing I want to avoid is having duplicate sets of data where you have to change something in two places. Since these are just getters, its fine.