search

bodil / purescript-sized-vectors

Idris style sized vectors in PureScript
18 stars 12 forks source link

Add Bind and Monad instances for Vec #18

Closed artemisSystem closed 4 years ago

artemisSystem commented 4 years ago

Will GitHub simply take care of it correctly if the first two commits are pulled via the apply instance PR? hope so

m-bock commented 4 years ago

Yes GitHub would take care of it correctly. But I'd suggest to not include unrelated previous commits in the PR's. As they don't build on top of each other. Just the things that are relevant for them.

But thanks for the PR's. They're awesome and should be merged in my view :)

artemisSystem commented 4 years ago

Ok, cool. I don't believe (at least in the case of this PR) that the previous commits were unrelated, as for the Monad instance to be lawful, the Apply one has to be as well, which it previously wasn't

The best idea would probably have been to add the commits right to the original PR though (unless github has something for conditional PRs?)