search

bodkan / slendr

Population genetic simulations in R 🌍
https://bodkan.net/slendr
Other
54 stars 5 forks source link

Fix undesirable artefacts during map zooming/cropping for some CRS #120

Closed bodkan closed 1 year ago

bodkan commented 1 year ago

This PR fixes issue #116. In particular, it reverses the order of CRS transformation -> cropping, into cropping -> CRS transformation as explained here.

This results in minor changes in the appearance of transformed maps (i.e. maps which use a projected CRS instead of the WGS-84/EPSG:4326 geodesic lat/lon coordinate system). The changes are, however, purely aesthetic and not functional. For an example see this.

codecov-commenter commented 1 year ago

Codecov Report

Merging #120 (24dcab8) into main (13133ed) will decrease coverage by 0.01%. The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
- Coverage   81.96%   81.96%   -0.01%     
==========================================
  Files           6        6              
  Lines        2967     2966       -1     
==========================================
- Hits         2432     2431       -1     
  Misses        535      535
Impacted Files Coverage Δ
R/interface.R 79.58% <80.00%> (-0.04%) :arrow_down:
R/compilation.R 89.35% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

bodkan commented 1 year ago

Plots in the vignette with examples from the slendr paper needed minor cosmetic updates. All done now.