search

bodkan / slendr

Population genetic simulations in R 🌍
https://bodkan.net/slendr
Other
54 stars 5 forks source link

remove rgdal asap #139

Closed rsbivand closed 1 year ago

rsbivand commented 1 year ago

Refer to https://r-spatial.org/r/2023/05/15/evolution4.html and earlier blogs, and remove retiring packages ASAP. In revdep checks with https://github.com/rsbivand/sp/tree/sp161 and https://r-forge.r-project.org/R/?group_id=884, rev. 1202, I see: 00check.log with testthat.Rout.zip

bodkan commented 1 year ago

Yes, I'm aware of this. We don't actually directly use rgdal at all. As far as I remember, I only added rgdal to package dependencies as a hack because rnaturalearth (or rnaturalearthdata?) was causing problems on some OS at some point. One of those packages failed if rgdal wasn't already present on the system, maybe they had misspecified dependency? I forget what it was exactly.

In any case, I will remove rgdal in the next release (soon).

rsbivand commented 1 year ago

rgdal 1.6-7 now on CRAN, so CRAN check failures will begin to show up very soon on: https://cran.r-project.org/web/checks/check_results_slendr.html; my CMD check with _SP_EVOLUTION_STATUS_=2 R CMD check: 00check.log

bodkan commented 1 year ago

The rgdal item under Suggests: has now been removed. I hastened the next release of slendr to push this ASAP -- the new version is on its way to CRAN now so I'm closing this issue. (Our only remaining geospatial dependencies are sf, stars, and rnaturalearth, so we should be good.)

Thanks for all your work, and for pushing me to finally do this.