Bug: Plug-in doesn't work with multipaged examples

bodleian / archiox-mirador-plugin

An experimental plugin to display depth information captured with Lucida or Selene scanners from FactumARTE. However, the plug-in can present any normal map/albedo map combination produced from any technique.

MIT License

1 stars 0 forks source link

Bug: Plug-in doesn't work with multipaged examples #110

Closed BeebBenjamin closed 2 months ago

BeebBenjamin commented 4 months ago

When changing page on a multipage test item on QA, the threejs layer doesn't seem to update to use the newest layers.

BeebBenjamin commented 3 months ago

Book view is broken with choices... so we should force Mirador to single page with the plug-in.

BeebBenjamin commented 3 months ago

Layers toggling also doesn't work with changing page, so, perhaps we add a handler for this.

BeebBenjamin commented 3 months ago

CanvasID needs to update each page turn.
Composite isn't the default choice for Nipponica, so we need to be able to configure the layers on an object by object basis.
Single page view needs to be handled on a object by object basis.

BeebBenjamin commented 3 months ago

If the torch isn't activated on the first page, the torch won't work on the subsequent pages... must be something to do with the way the ThreeCanvas is handled...

BeebBenjamin commented 2 months ago

Fix is on QA for testing.