search

bodleian / archiox-mirador-plugin

An experimental plugin to display depth information captured with Lucida or Selene scanners from FactumARTE. However, the plug-in can present any normal map/albedo map combination produced from any technique.
MIT License
1 stars 0 forks source link

Partial tiles with some images #113

Closed BeebBenjamin closed 2 months ago

BeebBenjamin commented 3 months ago

Due to differences in the keys used to get textures when we get to the three.js layer (caused by a rounding error, the difference of 1 pixel) the last row of tiled meshes is missing textures and rendered visible = False.

The fix is to make sure our tiling helper method uses the same rounding method as OpenSeadragon.

BeebBenjamin commented 3 months ago

I am testing a fix.

BeebBenjamin commented 3 months ago

OpenSeadragon uses Math.floor instead of Math.ceil.

BeebBenjamin commented 2 months ago

Fix is on QA for testing.