search

bodleian / charters

1 stars 0 forks source link

sorting of results #118

Closed holfordm closed 4 months ago

holfordm commented 11 months ago

I think this is currently done according to xml:id / url - it would be more logical have have an alphanumeric sort if possible

Slange-Mhath commented 11 months ago

That should be fixed with the latest commit. All on qa now. However, I found a few odd places after having sorted them alphabetically. It seems like they don't have a title and are not clickable. Not sure if thats a problem with the data? I could probably hide them with a workaround - but maybe it would be better to have a look at the data first Screenshot 2023-11-15 at 15 19 27 @irv?

Slange-Mhath commented 11 months ago

On QA now, but looks like these are blank entries. https://charters-qa.bodleian.ox.ac.uk/?f%5Btype%5D%5B%5D=place

irv commented 11 months ago

e.g.

               <placeName type="index"/>
               <placeName type="formInDocument"/>
               <region type="parish"/>
               <region type="county" key="place_000040">Lincolnshire</region>
               <idno/>
               <note type="charter"/>
            </place>
holfordm commented 11 months ago

should be fixed by e05da59d7c381ffbf7a908ca84287e79ca20ef1d

holfordm commented 11 months ago

sorting in charters runs 1, 10, 11, which may be unavoidable (?), but 1, 2, 3, ... 10, 11 would be preferable if possible

Slange-Mhath commented 11 months ago

seems like thats solved in the other catalogues through a sort_title field, which seems to work well for charters too. Will commit and push to QA.

Slange-Mhath commented 11 months ago

Let me know if you are happy with that, and I can deploy it on live too maybe?

holfordm commented 11 months ago

Looks good! baf1ceb91b8aa7e96a0a79724589df1d40f5e04b removes one more empty place