bodleian / charters

1 stars 0 forks source link

Aeon integration #47

Closed holfordm closed 1 year ago

holfordm commented 1 year ago

The orderable item is often a box or guardbook rather than the individual charter. This is captured in the TEI as follows: `MS. Ch. Eng. 1

MS. Ch. Eng. b. 1 `
Slange-Mhath commented 1 year ago

Hey Matthew, I am trying to adapt what we have for medieval to enable the aeon integration in charters too. It seems like it checks for requestable repositories and collections before rendering and enabling the actual request, and I just want to double check which collections are non requestable and which repositories are requestable. In medieval it looks like this: @@requestable_repositories = ['Bodleian Library', 'Jesus College', 'University College', 'University College (in progress)', 'Lincoln College', 'Trinity College', 'Trinity College (in progress)'] @@non_requestable_collections = ['Trinity College MS. fragments', 'Trinity College MS. fragments (in progress)']

andrew-morrison commented 1 year ago

Each TEI catalogue has different logic for whether to display a button to request each item via Aeon. It would probably be better to start with a blank slate and ask what the criteria should be for the charters catalogue. One or both of those lists may well be unnecessary, if there are no plans to include college-held charters, or no collection is inherently unrequestable. On the other hand, if it were decided not to allow requesting of charters with seals, or if all charters older than a certain age are considered too fragile, then that would require different code in the should_render_aeon_button? function.

andrew-morrison commented 1 year ago

Regarding different shelfmarks for the guardbook or box the individual charter is in, that will require changes to the indexing scripts. Unless the boxes and guardbooks are barcoded?

holfordm commented 1 year ago

Everything in the charters catalogue will be requestable, at least to start with - the only college collections are on deposit in the Bodleian

Slange-Mhath commented 1 year ago

Thank you both, thats really helpful! Guess I can loose that extra logic then :)