search

bodleian / charters

1 stars 0 forks source link

place index pages should show lists of related places #52

Closed holfordm closed 1 year ago

holfordm commented 1 year ago

For example, the index page for Suffolk (place_000070) should show a list of all places with <region key="000070">. Commit https://github.com/bodleian/charters/commit/12993e9a11eb9c4ea5ad1a34d68b5d93355cb5e4 added the relevant @key values to the region elements for counties. Similarly for areas which are not counties: for example the page for Chesham (place_108838) should show other places with <region key="108838">. Commit https://github.com/bodleian/charters/commit/7d0a7f775746a570c28374f2c6a33a0fee23f4f3 added the values for Chesham as a test in but in general the required values on region[@type='parish'] are not yet present.

The label above the list should be something like "Other places in this administrative area". The list should perhaps be in multiple columns to avoid too much scrolling.

holfordm commented 1 year ago

but perhaps this is already implemented, as I see that https://charters-qa.bodleian.ox.ac.uk/catalog/place_000070 shows a few related places as does https://charters-qa.bodleian.ox.ac.uk/catalog/place_102196 for a manor in that parish

irv commented 1 year ago

I've reindexed the Places with your latest commits. We're currently being a bit too helpful I think, showing all the places directly or indirectly associated with a place. I think with the changes to the dat awe might need to pare that back a bit to only direct relationships?