bodleian / iiif-manifest-editor

The Bodleian's IIIF Manifest Editor
http://dmt.bodleian.ox.ac.uk/
MIT License
82 stars 22 forks source link

Utilise POST for validating manifest rather than GET #9

Open chrxr opened 8 years ago

chrxr commented 8 years ago

Hi @schwemmer,

@calvinbutcher has had a pull request accepted to the IIIF validator, so it should now accept POST requests. Please could the manifest editor utilise this rather than GET via a 3rd party.

https://github.com/IIIF/presentation-api/pull/25

Note: route for POST is actually just /validate, not /postvalidate.

Thanks, Chris

schwemmer commented 8 years ago

Hi Chris,

Great, directly POSTing to the validator is certainly the better option, now that this is possible. There are a couple of minor issues that I need to sort out. I will comment on the validator Github repo (getting a CORS error and don't know how to specify the API version and what the POST parameter for the manifest data is).

chrxr commented 8 years ago

Also, thinking about it, they may not have deployed the changes yet. The POST parameter should be "json".

https://github.com/IIIF/presentation-api/blob/master/implementations/validator/validator.py#L72

schwemmer commented 8 years ago

Yes, that's it. Thanks!

schwemmer commented 7 years ago

See also this issue: https://github.com/IIIF/presentation-validator/issues/22

schwemmer commented 7 years ago

The issue with POSTing to the IIIF Presentation API validator has been resolved (cf. IIIF/presentation-validator#22). However, there now is a server configuration issue which prevents a large portion of the tested manifests to be validated successfully via POST because of "Error 413: Request Entity Too Large" (cf. IIIF/presentation-validator#53).

Before this is fixed, we should not merge the changes to master.