search

bodleian / ora_data_model

Documentation and crosswalks relating to the ORA data model
1 stars 1 forks source link

peer_review_status should not be set for deposits #164

Closed tomwrobel closed 4 years ago

tomwrobel commented 4 years ago

Vaguely related: https://github.com/tomwrobel/ora_data_model/issues/20

After discussion with @jjpartridge we do not want peer_review_status mapped from SE, as setting the value based on item types, which seems to be what is happening, is not accurate enough.

@mrdsaunders please amend the deposit crosswalk so that this value is no longer passed

This issue affects journal articles, conference items and, for some reason, internet publications. There may be other such works

Tracking ORA Trello tickets:

mrdsaunders commented 4 years ago

Confirming you mean this:

<mods:physicalDescription>
    <mods:form type="peer_reviewed">field:host_peer_review_status</mods:form>
</mods:physicalDescription>

It is currently always set to a value true but only for SE objects of type journal article (this may be historic based on AB originally putting it in field-map journal-markup but not actually intending to restrict it to journal articles only.

tomwrobel commented 4 years ago

@mrdsaunders I do. This should be removed from the active crosswalks