search

bodleian / ora_data_model

Documentation and crosswalks relating to the ORA data model
1 stars 1 forks source link

Prevent works with 'Draft' status from appearing in OAI-PMH feed #175

Open tomwrobel opened 4 years ago

tomwrobel commented 4 years ago

As a result of #174 , we know that failed deposits will leave draft works in ORA4 SYMP. No link between the Oxris and Hyrax objects has yet been created as this point (this is shown by the fact that redeposit creates a new item in Hyrax).

However, if the abandoned 'Draft' object is harvested, it may well appear in the Oxris record following harvest (the metadata will, after all, be close enough for a match in most cases).

I propose that we amend the OAI-PMH feed to ignore works with only a "Draft" status? In theory, we can add a record_filter to oai_config.rb as follows

record_filters: [
  '-workflow_state_name_ssim:"draft"'
]

Question to @mrdsaunders: Will this leave any objects in the lurch (e.g. those affected by #172)?

mrdsaunders commented 4 years ago

Hi Tom

Is workflow_state_name_ssim:"draft"' related to record_review_status?

Either way I don't think it will leave any in the lurch - assuming of course that the only 'draft' objects affected are these ones that have failed deposit.

To check I understand the situation, if we were to filter out the harvest of these 'drafts': Pros: If it was redeposited, prevents the creation of a duplicate ORA record. Cons: Fails to harvest data that was entered in good faith (but deposit failed)

Correct?