search

bodleian / ora_data_model

Documentation and crosswalks relating to the ORA data model
1 stars 1 forks source link

Switch "temp:value1" workaround to syntax released in 5.21 ($list.index) #186

Closed AndrewBennet closed 4 years ago

AndrewBennet commented 4 years ago

Hi all,

Just a note to say that we've added some built-in "list index access" functionality for Elements v5.21. Part of this work deprecated the workaround that was undocumented and in place for the Hyrax xwalk out role_order mappings (using "temp:value1" data-part).

I've switched these to use the new syntax (from="$list.index") - this should be applied when upgraded to Elements v5.21.

mrdsaunders commented 4 years ago

HI Andrew

Thanks very much for remembering this.... and doing it!

Best wishes

Dave

From: Andrew Bennet notifications@github.com Sent: 27 May 2020 17:21 To: tomwrobel/ora_data_model ora_data_model@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [tomwrobel/ora_data_model] Switch "temp:value1" workaround to syntax released in 5.21 ($list.index) (#186)

Hi all,

Just a note to say that we've added some built-in "list index access" functionality for Elements v5.21. Part of this work deprecated the workaround that was undocumented and in place for the Hyrax xwalk out role_order mappings (using "temp:value1" data-part).

I've switched these to use the new syntax (from="$list.index") - this should be applied when upgraded to Elements v5.21.

You can view, comment on, or merge this pull request online at:

https://github.com/tomwrobel/ora_data_model/pull/186

Commit Summary

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/tomwrobel/ora_data_model/pull/186, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACVAD44W27NEOVYB5UZ5O6DRTU4YXANCNFSM4NMJGA5Q.

tomwrobel commented 4 years ago

@mrdsaunders does this need to be re-tested?

mrdsaunders commented 4 years ago

Hi Tom

Toby and I tested it last week. This was after Tuula noticed an issue with author order in the upgrade testing so we resolved it.

Cheers

Dave

From: Tom Wrobel notifications@github.com Sent: 07 September 2020 11:03 To: tomwrobel/ora_data_model ora_data_model@noreply.github.com Cc: David Saunders david.saunders@admin.ox.ac.uk; Mention mention@noreply.github.com Subject: Re: [tomwrobel/ora_data_model] Switch "temp:value1" workaround to syntax released in 5.21 ($list.index) (#186)

@mrdsaundershttps://github.com/mrdsaunders does this need to be re-tested?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/tomwrobel/ora_data_model/pull/186#issuecomment-688218139, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACVAD4ZKSPBHULIZIFSL6ITSESVXNANCNFSM4NMJGA5Q.

tomwrobel commented 4 years ago

Brilliant, so no further action required?

mrdsaunders commented 4 years ago

No I think not.

mrdsaunders commented 4 years ago

Hi Andrew.

We have upgraded to 5.2.1 and implemented this change to the crosswalk. We notice that where there is a single author, the role_order is not being set i.e. there is no

 <mods:extension>
        <ora:role_order>1</ora:role_order>
 </mods:extension>

This is however being set for Depositor, but set 'manually' in the crosswalk (i.e. value = "1").

Is this intentional?

AndrewBennet commented 4 years ago

I've just raised another pull request to address this oversight: https://github.com/tomwrobel/ora_data_model/pull/189