search

bodleian / ora_data_model

Documentation and crosswalks relating to the ORA data model
1 stars 1 forks source link

'Hyrax-Work-Model' mapping for working papers - incorrect? #188

Open mrdsaunders opened 4 years ago

mrdsaunders commented 4 years ago

The deposit crosswalk mapping for ORA field Hyrax-Work-Model maps:

 <xwalk:value-mapping from="working-paper" to="WorkingPaper"/>

This is incorrect as the SE type for Working paper is actually `c-report'.

However we have successful deposited working papers. Can I check what the implications of the Hyrax-Work-Model field are?

e.g.: uuid_240648bf-373f-4f9d-aa7a-803c6e58147a

tomwrobel commented 4 years ago

I think the Oxris deposit crosswalk (i.e. the Oxris outbound crosswalk) has a value mapping from c-report to working paper (line 1231). Isn't this what's doing the work here?

uuid_240648bf-373f-4f9d-aa7a-803c6e58147a was deposited as a working paper, and there's nothing in the Hyrax/Sword code to translate c-report into working paper, so it must be working in the Oxris outbound (deposit) crosswalk). You're right that I can't find out where. Annoyingly, the new crosswalk engine in Oxris doesn't show header output.

mrdsaunders commented 4 years ago

The ora-work-type-mappings (c-report -> Working paper) seems to be doing the work to write to genre type.

I can only assume that the Hyrax-work-model for the following is not working: <xwalk:value-mapping from="working-paper" to="WorkingPaper"/> but it has no implication.

I will set it to in any case, but are you saying we effectively have no way of testing it?

tomwrobel commented 4 years ago

We CAN test it, although not today or tomorrow. What we can't do is test it using the tools built in to Oxris. We'll have to just set it, try a deposit, and see.

The crosswalk testing engine in 5.21 has been updated, and doesn't output the HEADER content in the crosswalk test output