search

bodleian / ora_data_model

Documentation and crosswalks relating to the ORA data model
1 stars 1 forks source link

Type of work and sub-type-of-work mappings #53

Closed tomwrobel closed 4 years ago

tomwrobel commented 5 years ago

Related to #7 and #51

A list of mapping instructions for ORA fields type_of_work and sub_type_of_work has been added to the mappings file instructions

Some of these are moderately complex and will require discussion.

https://github.com/tomwrobel/ora_data_model/blob/9fda618eda8086f5fd0f5d51a0e5b1925a6c3f60/symplectic_to_ora_field_mapping-2.0.xml#L556-L743

@AndrewBennet do you understand the mappings, and can the engine do these mappings?

jjpartridge commented 5 years ago

@tomwrobel This looks good to me - thanks

tomwrobel commented 5 years ago

@AndrewBennet can you do the double-check as discussed and then close?

tomwrobel commented 5 years ago

Sub types are not being correctly mapped, we'll need to fix this in crosswalks (I don't know where the error lies!)

tomwrobel commented 5 years ago

@jjpartridge what is the status of these? Has it been subsumed into another ticket?

jjpartridge commented 5 years ago

@tomwrobel I don't know the answer to that am assuming that @mrdsaunders has accounted for this though in the mappings?

mrdsaunders commented 5 years ago

Subtypes are in the crosswalks - testing will tell whether they are working!

Deposit/Harvest SE type <-> ORA type/subtype Deposit/Harvest SE journal article subtype field <-> ORA journal article subtypes

tomwrobel commented 5 years ago

@mrdsaunders can you close this ticket when you or @tobypitts and @jjpartridge are happy with the outcome?