search

bodleian / oxford-explorer

The culmination of our previous R&D into the Oxford work. Now we have a Thing.
0 stars 2 forks source link

Handle .pretend links #47

Closed infovore closed 7 years ago

infovore commented 7 years ago

Any pretend links that are clickable should do something when they're clicked, even if that's just a javascript popup.

@infovore's suggestion: stick a data-pretend-reason attribute on the link, and if it's present, use it to populate a JS popup.

frankieroberto commented 7 years ago

This is done, in a basic way (e.g. see links from https://gfs-oxford-explorer.herokuapp.com/collections/ash-ancient-agean)

infovore commented 7 years ago

In which case, pinging to @george08 for approval.

george08 commented 7 years ago

Great! Will have to remember this to add more notes.