search

bodono / scs-python

Python interface for SCS
MIT License
41 stars 33 forks source link

Test correctness of GPU paths #40

Closed h-vetinari closed 3 years ago

h-vetinari commented 3 years ago

Since #37, solve_random_cone_prob.py was upgraded to a test, but it only tests execution and not correctness of the gpu code; this is an issue for determining whether platforms (e.g. windows) produce the correct output, especially in the presence of errors like the following (which may or may not be related to different issues like not enough GPU memory):

scs/linsys/gpu\gpu.c:12:scs__accum_by_atrans_gpu
 ERROR_CUDA: an illegal memory access was encountered

@bodono mentioned in #37:

I will update the tests so that they test numerical correctness next.

Just opening an issues so we can track this, because GPU support for scs in conda-forge depends on being able to verify at least (basic) correctness: https://github.com/conda-forge/scs-feedstock/pull/21

h-vetinari commented 3 years ago

@bonodo Any update on this? 🙃 conda-forge/scs-feedstock#21 is currently waiting on verifying the correctness of the GPU paths.

h-vetinari commented 3 years ago

Thanks a lot! :)

I've triggered new builds in https://github.com/conda-forge/scs-feedstock/pull/21, will see if they pass the correctness tests (particularly on windows).