Export doesn't return error status when failing

bodrovis / lokalise_rails

Ruby on Rails integration for Lokalise

MIT License

17 stars 3 forks source link

Export doesn't return error status when failing #5

Closed feliciegodineau closed 3 years ago

feliciegodineau commented 3 years ago

Describe the bug export rake doesn't exit with an error status code when it fails.

To Reproduce This can be reproduce by having an invalid yml file and trying to export it usingbundle exec rails lokalise_rails:export.

Expected behavior We expect bundle exec rails lokalise_rails:export to return 1 when it fails to export files.

Your environment:

Ruby 2.7.1

bodrovis commented 3 years ago

Thank you, I'll check within the next few days!

bodrovis commented 3 years ago

@feliciegodineau Okay, so I've just released v1.4.0 which should hopefully do the trick. Now when something goes wrong we call abort with the actual error message. It raises SystemExit which basically means status code 1. However, if this still doesn't work please let me know.

feliciegodineau commented 3 years ago

Just updated it and it's working great 👍 Thank you!

bodrovis commented 3 years ago

@feliciegodineau Oh, that's great :) 👍