[FEATURE] Replace Hugo's built-in shortcode for Youtube - Githubissues

boechat107 / LoveIt

❤️A clean, elegant but advanced blog theme for Hugo 一个简洁、优雅且高效的 Hugo 主题

https://hugoloveit.com

MIT License

0 stars 0 forks source link

[FEATURE] Replace Hugo's built-in shortcode for Youtube #2

Open boechat107 opened 3 years ago

boechat107 commented 3 years ago

What

Add a more efficient shortcode for Youtube videos.

Why

The result page gets low scores on PageSpeed Insights.
Hugo's contributors are talking about removing this kind of shortcuts (https://github.com/gohugoio/hugo/issues/7893).

Questions

Replace it with an image?
Or a simple link?

josineto commented 3 years ago

Hi, I reached this issue from gohugoio/hugo#7893. Soon after that, I found an article in loading youtube video just as user clicks play button.

I'm currently adapting that solution to my site (I don't use LoveIt):

support no-javascript: turning the root div into an anchor with href to the YouTube video, and removing that href with javascript
clean styles
use an SVG image as play button
put all that in a partial/shortcode

I think that solution is the best compromise, and could be useful for you too.