boehs / Lightly

A modern style for qt applications.
Other
214 stars 10 forks source link

Add support for plasma 6 #13

Open chicco-carone opened 11 months ago

chicco-carone commented 11 months ago

I just finished updating to plasma 6 beta 1 and this style is not present anymore in the settings since it has to be ported to qt6.

murakami-marco commented 8 months ago

I succesfully compile but getting this image

I follow all the recomendations like Switched to qt6 branch, added lightlystyleconfig.json to /kstyle/config and pulled CMakeLists.txt, kcm_lightlydecoration.{json,cpp} from the config.tar.gz to kdecoration/config. Cd'd into /build/kdecoration/config/ i executed make and it generated the ui_lightlyconfigurationui.h then resumed the normal compilation with make in /build/ directory then sudo make install.

I'm on KDE Neon

This is the output on cmake

cmake -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_LIBDIR=lib64 -DBUILD_TESTING=OFF ..
-- The C compiler identification is GNU 11.4.0
-- The CXX compiler identification is GNU 11.4.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for __GLIBC__
-- Looking for __GLIBC__ - found
-- Performing Test _OFFT_IS_64BIT
-- Performing Test _OFFT_IS_64BIT - Success
-- Performing Test HAVE_DATE_TIME
-- Performing Test HAVE_DATE_TIME - Success
-- Installing in the same prefix as Qt, adopting their path scheme.
-- Performing Test HAVE_STDATOMIC
-- Performing Test HAVE_STDATOMIC - Success
-- Found WrapAtomic: TRUE
-- Found OpenGL: /usr/lib/x86_64-linux-gnu/libOpenGL.so
-- Found WrapOpenGL: TRUE
-- Found XKB: /usr/lib/x86_64-linux-gnu/libxkbcommon.so (found suitable version "1.4.0", minimum required is "0.5.0")
-- Found WrapVulkanHeaders: /usr/include
-- Found KF6CoreAddons: /usr/lib/x86_64-linux-gnu/cmake/KF6CoreAddons/KF6CoreAddonsConfig.cmake (found version "6.0.0")
-- Found KF6ColorScheme: /usr/lib/x86_64-linux-gnu/cmake/KF6ColorScheme/KF6ColorSchemeConfig.cmake (found version "6.0.0")
-- Found KF6Config: /usr/lib/x86_64-linux-gnu/cmake/KF6Config/KF6ConfigConfig.cmake (found version "6.0.0")
-- Found KF6GuiAddons: /usr/lib/x86_64-linux-gnu/cmake/KF6GuiAddons/KF6GuiAddonsConfig.cmake (found version "6.0.0")
-- Found Gettext: /usr/bin/msgmerge (found version "0.21")
-- Found KF6I18n: /usr/lib/x86_64-linux-gnu/cmake/KF6I18n/KF6I18nConfig.cmake (found version "6.0.0")
-- Found KF6IconThemes: /usr/lib/x86_64-linux-gnu/cmake/KF6IconThemes/KF6IconThemesConfig.cmake (found version "6.0.0")
-- Found X11: /usr/include
-- Looking for XOpenDisplay in /usr/lib/x86_64-linux-gnu/libX11.so;/usr/lib/x86_64-linux-gnu/libXext.so
-- Looking for XOpenDisplay in /usr/lib/x86_64-linux-gnu/libX11.so;/usr/lib/x86_64-linux-gnu/libXext.so - found
-- Looking for gethostbyname
-- Looking for gethostbyname - found
-- Looking for connect
-- Looking for connect - found
-- Looking for remove
-- Looking for remove - found
-- Looking for shmat
-- Looking for shmat - found
-- Looking for IceConnectionNumber in ICE
-- Looking for IceConnectionNumber in ICE - found
-- Found KF6WindowSystem: /usr/lib/x86_64-linux-gnu/cmake/KF6WindowSystem/KF6WindowSystemConfig.cmake (found version "6.0.0")
-- Found KF6: success (found suitable version "6.0.0", minimum required is "5.240.0") found components: CoreAddons ColorScheme Config GuiAddons I18n IconThemes WindowSystem
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- The following OPTIONAL packages have been found:

* OpenGL
* Vulkan
* Qt6DBusTools (required version >= 6.6.2)
* Qt6WidgetsTools (required version >= 6.6.2)
* Qt6Widgets (required version >= 6.5.0)
* Freetype
* Fontconfig
* Qt6CoreTools (required version >= 6.6.2)
* Qt6QmlTools (required version >= 6.6.2)
* KF6FrameworkIntegration (required version >= 5.240.0), KF6 Framework Integration, <https://projects.kde.org/projects/frameworks/frameworkintegration>
Required to use KStyle convenience functionalities in style
* PkgConfig
* XKB (required version >= 0.5.0), XKB API common to servers and clients., <http://xkbcommon.org>
* WrapVulkanHeaders
* Qt6GuiTools (required version >= 6.6.2)
* Git

-- The following REQUIRED packages have been found:

* ECM (required version >= 5.240.0)
* KF6Config (required version >= 5.240.0)
* KF6GuiAddons (required version >= 5.240.0)
* Gettext
* KF6I18n (required version >= 5.240.0)
* KF6WindowSystem (required version >= 5.240.0)
* KF6 (required version >= 5.240.0)
* KF6ColorScheme (required version >= 6.0.0)
* KF6CoreAddons (required version >= 6.0.0)
* KF6KCMUtils (required version >= 5.240.0), Helps create configuration modules
KCMUtils used for the configuration modules or the decoration and Qt Style
* Qt6Quick (required version >= 6.5.0)
* KF6KirigamiPlatform (required version >= 5.240.0)
* KF6IconThemes (required version >= 6.0.0)
* Qt6
* KDecoration2

-- The following OPTIONAL packages have not been found:

* Qt6QmlCompilerPlusPrivate

-- Configuring done (1.5s)
-- Generating done (0.0s)
-- Build files have been written to: /home/marco/Plasma/Lightly/build

And this is the output for sudo make install

sudo make install
[  0%] Built target lightlycommon6_autogen_timestamp_deps
[  1%] Built target lightlycommon6_autogen
[  5%] Built target lightlycommon6
[  5%] Built target lightly6_autogen_timestamp_deps
[  6%] Built target lightly6_autogen
[ 54%] Built target lightly6
[ 54%] Built target lightlystyleconfig-kcm-desktop-gen
[ 54%] Built target lightlystyleconfig_autogen_timestamp_deps
[ 55%] Built target lightlystyleconfig_autogen
[ 64%] Built target lightlystyleconfig
[ 64%] Built target lightly-settings_autogen_timestamp_deps
[ 65%] Built target lightly-settings_autogen
[ 69%] Built target lightly-settings
[ 69%] Built target lightlydecoration_autogen_timestamp_deps
[ 70%] Built target lightlydecoration_autogen
[ 81%] Built target lightlydecoration
[ 81%] Built target kcm_lightlydecoration-kcm-desktop-gen
[ 81%] Built target kcm_lightlydecoration_autogen_timestamp_deps
[ 82%] Built target kcm_lightlydecoration_autogen
[100%] Built target kcm_lightlydecoration
Install the project...
-- Install configuration: "Release"
-- Up-to-date: /usr/share/color-schemes/Lightly.colors
-- Installing: /usr/lib/x86_64-linux-gnu/qt6/plugins/styles/lightly6.so
-- Set non-toolchain portion of runtime path of "/usr/lib/x86_64-linux-gnu/qt6/plugins/styles/lightly6.so" to ""
-- Up-to-date: /usr/share/kstyle/themes/lightly.themerc
-- Installing: /usr/lib/x86_64-linux-gnu/qt6/plugins/kstyle_config/lightlystyleconfig.so
-- Installing: /usr/share/applications/lightlystyleconfig.desktop
-- Installing: /usr/bin/lightly-settings6
-- Up-to-date: /usr/share/icons/hicolor/scalable/apps/lightly-settings.svgz
-- Installing: /usr/lib64/liblightlycommon6.so.6.80
-- Up-to-date: /usr/lib64/liblightlycommon6.so.6
-- Installing: /usr/lib/x86_64-linux-gnu/qt6/plugins/org.kde.kdecoration2/org.kde.lightly.so
-- Set non-toolchain portion of runtime path of "/usr/lib/x86_64-linux-gnu/qt6/plugins/org.kde.kdecoration2/org.kde.lightly.so" to ""
-- Up-to-date: /usr/share/kservices6/lightlydecorationconfig.desktop
-- Installing: /usr/lib/x86_64-linux-gnu/qt6/plugins/org.kde.kdecoration2.kcm/kcm_lightlydecoration.so
-- Installing: /usr/share/applications/kcm_lightlydecoration.desktop
-- Installing: /usr/lib64/cmake/Lightly/LightlyConfig.cmake
-- Installing: /usr/lib64/cmake/Lightly/LightlyConfigVersion.cmake

Not sure if it's because the missing optional package. I don't think so because it's optional but I don't have a clue.

Help please.

Thanks!!

p0ryae commented 8 months ago

I follow all the recomendations like Switched to qt6 branch, added lightlystyleconfig.json to /kstyle/config and pulled CMakeLists.txt, kcm_lightlydecoration.{json,cpp} from the config.tar.gz to kdecoration/config.

I followed the steps above exactly except the Cd'd into /build/kdecoration/config/ i executed make and it generated the ui_lightlyconfigurationui.h part, and everything works perfectly fine for me, and Lightly shows up in system settings, and applies correctly.

image

FantasyPvP commented 8 months ago

I follow all the recomendations like Switched to qt6 branch, added lightlystyleconfig.json to /kstyle/config and pulled CMakeLists.txt, kcm_lightlydecoration.{json,cpp} from the config.tar.gz to kdecoration/config.

I followed the steps above exactly except the Cd'd into /build/kdecoration/config/ i executed make and it generated the ui_lightlyconfigurationui.h part, and everything works perfectly fine for me, and Lightly shows up in system settings, and applies correctly.

image

Just wondering is that the sweet theme you've got there? I recognise the window buttons. That combination with the lightly desktop theme looks so clean I'm def gonna have to try that XD

p0ryae commented 8 months ago

Just wondering is that the sweet theme you've got there? I recognise the window buttons. That combination with the lightly desktop theme looks so clean I'm def gonna have to try that XD

I use McVentura Dark for Plasma Style, Ullterly Round Dark solid for window decorations, Tela Circle Dark for icons, ChromeOSKDE Darknes (with some slight modifications) for colors, and for rounded corners I use LightlyShaders plasma6 branch. Some are tuned according to preference, but should be straightforward, otherwise. Hope that helps.

FantasyPvP commented 8 months ago

Just wondering is that the sweet theme you've got there? I recognise the window buttons. That combination with the lightly desktop theme looks so clean I'm def gonna have to try that XD

I use McVentura Dark for Plasma Style, Ullterly Round Dark solid for window decorations, Tela Circle Dark for icons, ChromeOSKDE Darknes (with some slight modifications) for colors, and for rounded corners I use LightlyShaders plasma6 branch. Some are tuned according to preference, but should be straightforward, otherwise. Hope that helps.

Thanks I'll have a look at those themes

CrabbyDisk commented 8 months ago

I am having issues installing lightly on plasma 6. cmake -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_LIBDIR=lib64 -DBUILD_TESTING=OFF .. gives me an error message:

CMake Error at /usr/lib/cmake/KF6CoreAddons/KF6CoreAddonsMacros.cmake:29 (message):
  Must specify INSTALL_NAMESPACE for kcm_lightlydecoration
Call Stack (most recent call first):
  kstyle/CMakeLists.txt:19 (kcoreaddons_add_plugin)

I should have done all the steps shown in this thread.

TuxTheAstronaut commented 8 months ago

when i compile config/ui_lightlyconfigurationui.h isn't being generated and i tried doing what someone else above said by going into the make file of that directory and even tho its now generated it still says it cant find the file so anyone know what am i doing wrong?

HikariNeee commented 8 months ago

I can confirm that it compiles successfully and the team works completely fine. I did use config.tar.gz instead of generating manually.

MicrogamerCz commented 8 months ago

I followed these instructions as best as I could, but I can't make the build/kdecoration/config for the "ui_lightlyconfigurationui.h"

obrazek

I'm using KDE Neon and based on the type I think it needs kf6-kwindowsystem which I already have installed

I cloned the repo and downloaded the files from here, put the files from the tar to kdecoration/config, put the json in kstyle/config, then used the cmake command also from this PR in build/, used make, cd to kdecoration/config and again make and there this error happened.

HikariNeee commented 8 months ago

In my case I did not need to build ui_lightlyconfiguration.h. Does it not build if you do these steps? https://github.com/boehs/Lightly/issues/13#issuecomment-1974016287

MicrogamerCz commented 8 months ago

I used this cmake build command:

cmake -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_LIBDIR=lib64 -DBUILD_TESTING=OFF ..

then make and I got this error which I expected based on other replies image about 'ui_lightlyconfiguration.h' missing, so I used make in build/kdecoration/config where I got the errors with KWindowInfo

Lymia commented 8 months ago
{
    fetchFromGitHub,
    mkKdeDerivation,
    extra-cmake-modules,
    kdecoration,
    plasma-workspace,
    qtbase,
    fetchurl,
}:

mkKdeDerivation rec {
    pname = "lightly-qt6";
    version = "0.4.1";

    src = fetchFromGitHub {
        owner = "boehs";
        repo = "Lightly";
        rev = "00ca23447844114d41bfc0d37cf8823202c082e8";
        sha256 = "sha256-NpgOcN9sDqgQMjqcfx92bfKohxaJpnwMgxb9MCu9uJM=";
    };

    patchPhase =
        let
            config-tar-gz = fetchurl {
                url = "https://github.com/boehs/Lightly/files/14445309/config.tar.gz";
                sha256 = "sha256-eCIRm2z1+eTBcCCg8Wdt2DfTTbc767Rv+m1LI+t058I=";
            };
            lightlystyleconfig-json = fetchurl {
                url = "https://github.com/boehs/Lightly/files/14444935/lightlystyleconfig.json";
                sha256 = "sha256-ORQk0QirDB9dF3RdgmH5sstqQqqSEfOE6lh1YEUz+iM=";
            };
        in ''
            mkdir tmp
            cd tmp
            tar -xv -f ${config-tar-gz}
            cd ..

            cp -v tmp/config/CMakeLists.txt kdecoration/config/CMakeLists.txt
            cp -v tmp/config/kcm_lightlydecoration.json kdecoration/config/kcm_lightlydecoration.json
            cp -v tmp/config/kcm_lightlydecoration.cpp kdecoration/config/kcm_lightlydecoration.cpp
            cp -v ${lightlystyleconfig-json} kstyle/config/lightlystyleconfig.json
        '';

    extraBuildInputs = [
        kdecoration
        plasma-workspace
        extra-cmake-modules
    ];
}

Here's a compiling nix derivation for the qt6 version of lightly. Still testing if it works.

(call it like this:)

lightly-qt6 = pkgs.kdePackages.callPackage ./apps/lightly-qt6.nix {};

EDIT: Can confirm it works.

radiolamp commented 8 months ago

I followed the instructions, but got an error: [ 53%] Linking CXX shared module ../bin/lightly6.so [ 54%] Built target lightly6 Could not open file "/home/radio/Ð\u0097агÑ\u0080Ñ\u0083зки/Lightly-qt6/kstyle/config/lightlystyleconfig.json" make[2]: [kstyle6/config/CMakeFiles/lightlystyleconfig-kcm-desktop-gen.dir/build.make:70: kstyle6/config/CMakeFiles/lightlystyleconfig-kcm-desktop-gen] Ошибка 1 make[1]: [CMakeFiles/Makefile2:688: kstyle6/config/CMakeFiles/lightlystyleconfig-kcm-desktop-gen.dir/all] Ошибка 2 make: *** [Makefile:136: all] Ошибка 2

Tell me what could be the problem?

xkain commented 8 months ago

I succesfully compile but getting this image

I follow all the recomendations like Switched to qt6 branch, added lightlystyleconfig.json to /kstyle/config and pulled CMakeLists.txt, kcm_lightlydecoration.{json,cpp} from the config.tar.gz to kdecoration/config. Cd'd into /build/kdecoration/config/ i executed make and it generated the ui_lightlyconfigurationui.h then resumed the normal compilation with make in /build/ directory then sudo make install.

I'm on KDE Neon

This is the output on cmake

cmake -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_LIBDIR=lib64 -DBUILD_TESTING=OFF ..
-- The C compiler identification is GNU 11.4.0
-- The CXX compiler identification is GNU 11.4.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for __GLIBC__
-- Looking for __GLIBC__ - found
-- Performing Test _OFFT_IS_64BIT
-- Performing Test _OFFT_IS_64BIT - Success
-- Performing Test HAVE_DATE_TIME
-- Performing Test HAVE_DATE_TIME - Success
-- Installing in the same prefix as Qt, adopting their path scheme.
-- Performing Test HAVE_STDATOMIC
-- Performing Test HAVE_STDATOMIC - Success
-- Found WrapAtomic: TRUE
-- Found OpenGL: /usr/lib/x86_64-linux-gnu/libOpenGL.so
-- Found WrapOpenGL: TRUE
-- Found XKB: /usr/lib/x86_64-linux-gnu/libxkbcommon.so (found suitable version "1.4.0", minimum required is "0.5.0")
-- Found WrapVulkanHeaders: /usr/include
-- Found KF6CoreAddons: /usr/lib/x86_64-linux-gnu/cmake/KF6CoreAddons/KF6CoreAddonsConfig.cmake (found version "6.0.0")
-- Found KF6ColorScheme: /usr/lib/x86_64-linux-gnu/cmake/KF6ColorScheme/KF6ColorSchemeConfig.cmake (found version "6.0.0")
-- Found KF6Config: /usr/lib/x86_64-linux-gnu/cmake/KF6Config/KF6ConfigConfig.cmake (found version "6.0.0")
-- Found KF6GuiAddons: /usr/lib/x86_64-linux-gnu/cmake/KF6GuiAddons/KF6GuiAddonsConfig.cmake (found version "6.0.0")
-- Found Gettext: /usr/bin/msgmerge (found version "0.21")
-- Found KF6I18n: /usr/lib/x86_64-linux-gnu/cmake/KF6I18n/KF6I18nConfig.cmake (found version "6.0.0")
-- Found KF6IconThemes: /usr/lib/x86_64-linux-gnu/cmake/KF6IconThemes/KF6IconThemesConfig.cmake (found version "6.0.0")
-- Found X11: /usr/include
-- Looking for XOpenDisplay in /usr/lib/x86_64-linux-gnu/libX11.so;/usr/lib/x86_64-linux-gnu/libXext.so
-- Looking for XOpenDisplay in /usr/lib/x86_64-linux-gnu/libX11.so;/usr/lib/x86_64-linux-gnu/libXext.so - found
-- Looking for gethostbyname
-- Looking for gethostbyname - found
-- Looking for connect
-- Looking for connect - found
-- Looking for remove
-- Looking for remove - found
-- Looking for shmat
-- Looking for shmat - found
-- Looking for IceConnectionNumber in ICE
-- Looking for IceConnectionNumber in ICE - found
-- Found KF6WindowSystem: /usr/lib/x86_64-linux-gnu/cmake/KF6WindowSystem/KF6WindowSystemConfig.cmake (found version "6.0.0")
-- Found KF6: success (found suitable version "6.0.0", minimum required is "5.240.0") found components: CoreAddons ColorScheme Config GuiAddons I18n IconThemes WindowSystem
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- The following OPTIONAL packages have been found:

* OpenGL
* Vulkan
* Qt6DBusTools (required version >= 6.6.2)
* Qt6WidgetsTools (required version >= 6.6.2)
* Qt6Widgets (required version >= 6.5.0)
* Freetype
* Fontconfig
* Qt6CoreTools (required version >= 6.6.2)
* Qt6QmlTools (required version >= 6.6.2)
* KF6FrameworkIntegration (required version >= 5.240.0), KF6 Framework Integration, <https://projects.kde.org/projects/frameworks/frameworkintegration>
Required to use KStyle convenience functionalities in style
* PkgConfig
* XKB (required version >= 0.5.0), XKB API common to servers and clients., <http://xkbcommon.org>
* WrapVulkanHeaders
* Qt6GuiTools (required version >= 6.6.2)
* Git

-- The following REQUIRED packages have been found:

* ECM (required version >= 5.240.0)
* KF6Config (required version >= 5.240.0)
* KF6GuiAddons (required version >= 5.240.0)
* Gettext
* KF6I18n (required version >= 5.240.0)
* KF6WindowSystem (required version >= 5.240.0)
* KF6 (required version >= 5.240.0)
* KF6ColorScheme (required version >= 6.0.0)
* KF6CoreAddons (required version >= 6.0.0)
* KF6KCMUtils (required version >= 5.240.0), Helps create configuration modules
KCMUtils used for the configuration modules or the decoration and Qt Style
* Qt6Quick (required version >= 6.5.0)
* KF6KirigamiPlatform (required version >= 5.240.0)
* KF6IconThemes (required version >= 6.0.0)
* Qt6
* KDecoration2

-- The following OPTIONAL packages have not been found:

* Qt6QmlCompilerPlusPrivate

-- Configuring done (1.5s)
-- Generating done (0.0s)
-- Build files have been written to: /home/marco/Plasma/Lightly/build

And this is the output for sudo make install

sudo make install
[  0%] Built target lightlycommon6_autogen_timestamp_deps
[  1%] Built target lightlycommon6_autogen
[  5%] Built target lightlycommon6
[  5%] Built target lightly6_autogen_timestamp_deps
[  6%] Built target lightly6_autogen
[ 54%] Built target lightly6
[ 54%] Built target lightlystyleconfig-kcm-desktop-gen
[ 54%] Built target lightlystyleconfig_autogen_timestamp_deps
[ 55%] Built target lightlystyleconfig_autogen
[ 64%] Built target lightlystyleconfig
[ 64%] Built target lightly-settings_autogen_timestamp_deps
[ 65%] Built target lightly-settings_autogen
[ 69%] Built target lightly-settings
[ 69%] Built target lightlydecoration_autogen_timestamp_deps
[ 70%] Built target lightlydecoration_autogen
[ 81%] Built target lightlydecoration
[ 81%] Built target kcm_lightlydecoration-kcm-desktop-gen
[ 81%] Built target kcm_lightlydecoration_autogen_timestamp_deps
[ 82%] Built target kcm_lightlydecoration_autogen
[100%] Built target kcm_lightlydecoration
Install the project...
-- Install configuration: "Release"
-- Up-to-date: /usr/share/color-schemes/Lightly.colors
-- Installing: /usr/lib/x86_64-linux-gnu/qt6/plugins/styles/lightly6.so
-- Set non-toolchain portion of runtime path of "/usr/lib/x86_64-linux-gnu/qt6/plugins/styles/lightly6.so" to ""
-- Up-to-date: /usr/share/kstyle/themes/lightly.themerc
-- Installing: /usr/lib/x86_64-linux-gnu/qt6/plugins/kstyle_config/lightlystyleconfig.so
-- Installing: /usr/share/applications/lightlystyleconfig.desktop
-- Installing: /usr/bin/lightly-settings6
-- Up-to-date: /usr/share/icons/hicolor/scalable/apps/lightly-settings.svgz
-- Installing: /usr/lib64/liblightlycommon6.so.6.80
-- Up-to-date: /usr/lib64/liblightlycommon6.so.6
-- Installing: /usr/lib/x86_64-linux-gnu/qt6/plugins/org.kde.kdecoration2/org.kde.lightly.so
-- Set non-toolchain portion of runtime path of "/usr/lib/x86_64-linux-gnu/qt6/plugins/org.kde.kdecoration2/org.kde.lightly.so" to ""
-- Up-to-date: /usr/share/kservices6/lightlydecorationconfig.desktop
-- Installing: /usr/lib/x86_64-linux-gnu/qt6/plugins/org.kde.kdecoration2.kcm/kcm_lightlydecoration.so
-- Installing: /usr/share/applications/kcm_lightlydecoration.desktop
-- Installing: /usr/lib64/cmake/Lightly/LightlyConfig.cmake
-- Installing: /usr/lib64/cmake/Lightly/LightlyConfigVersion.cmake

Not sure if it's because the missing optional package. I don't think so because it's optional but I don't have a clue.

Help please.

Thanks!!

Hi,

I'm also on KDE Neon but I can't compile, have you succeeded since then and what steps did you take?

EDIT: Finaly have the same : Copie d'écran_20240325_182505

xkain commented 8 months ago

Hi,

Lightly now works on my KDE Neon but I have some display bugs:

Copie d'écran_20240325_221052

hazel-bunny commented 8 months ago

Hi,

Lightly now works on my KDE Neon but I have some display bugs:

Copie d'écran_20240325_221052

Not reproducible in Fedora

Screenshot_20240328_192542

alexhulbert commented 8 months ago

Just want to add that everything is working perfectly for me too! In fact, I was seeing some artifacts on qt5 that actually disappeared in qt6+lightly. Is there anything left preventing an aur release?

hazel-bunny commented 8 months ago

@alexhulbert lightly-qt6-git with a patch is already on aur and copr. @boehs needs to tag a release at first if you want an actual "release" on aur. There are outstanding bugs though that are present in both luwx and boehs versions.

alexhulbert commented 8 months ago

@alexhulbert lightly-qt6-git with a patch is already on aur and copr. @boehs needs to tag a release at first if you want an actual "release" on aur. There are outstanding bugs though that are present in both luwx and boehs versions.

Oh my bad, I must have missed that. Thanks!

boehs commented 8 months ago

Sorry yall, I'm immensely busy with various personal things that have cropped up in the past month. I'd still consider this fork maintainedish, I just need to deal with the other stuff first.

By the way, I'm mildly interested in adding another maintainer to handle stuff like this, I'll give it more thought soon.

Again I'm immensely sorry, I know I said it'd be done a few weeks ago but that's just the way life be sometimes

AlphaCraft9658 commented 7 months ago

Sorry yall, I'm immensely busy with various personal things that have cropped up in the past month. I'd still consider this fork maintainedish, I just need to deal with the other stuff first.

By the way, I'm mildly interested in adding another maintainer to handle stuff like this, I'll give it more thought soon.

Again I'm immensely sorry, I know I said it'd be done a few weeks ago but that's just the way life be sometimes

I wish I could help with maintaining amazing projects like this one, but I'm currently lacking the skill and even the time to do so. School is keeping me busy, and I am doing my best to get the Abitur, which is a German degree. I wish you the best of luck with your stuff and hope you can handle it smoothly!

OzzyHelix commented 7 months ago

Sorry yall, I'm immensely busy with various personal things that have cropped up in the past month. I'd still consider this fork maintainedish, I just need to deal with the other stuff first.

By the way, I'm mildly interested in adding another maintainer to handle stuff like this, I'll give it more thought soon.

Again I'm immensely sorry, I know I said it'd be done a few weeks ago but that's just the way life be sometimes

I would be careful about adding another maintainer after the xz situation making sure your maintainers aren't bad actors should be part of the consideration of choosing a maintainer

AlphaCraft9658 commented 6 months ago

Sorry yall, I'm immensely busy with various personal things that have cropped up in the past month. I'd still consider this fork maintainedish, I just need to deal with the other stuff first.

By the way, I'm mildly interested in adding another maintainer to handle stuff like this, I'll give it more thought soon.

Again I'm immensely sorry, I know I said it'd be done a few weeks ago but that's just the way life be sometimes

Hi! How are you doing? I'm interested in hearing about whether stuff goes well right now, that you're not having troubles with the things you need to do in your personal life. I appreciate the work developers put into these kinds of projects and want them to be doing well, as I know how hard such things can get, especially when there are other things that need attention. Hopefully, you will soon be able to also get this issue dealt with as well and with a fresh mind. 👍🏻

boehs commented 6 months ago

I would be careful about adding another maintainer after the xz situation making sure your maintainers aren't bad actors should be part of the consideration of choosing a maintainer

I'm aware — I spent much of the week after the incident documenting the bug in an article referenced by the NYT and NIST. That was a significant time sink.


Thank you for your support @AlphaCraft9658

OzzyHelix commented 6 months ago

I would be careful about adding another maintainer after the xz situation making sure your maintainers aren't bad actors should be part of the consideration of choosing a maintainer

I'm aware — I spent much of the week after the incident documenting the bug in an article referenced by the NYT and NIST. That was a significant time sink.

Thank you for your support @AlphaCraft9658

my concern is just having another xz situation because of a maintainer with malicious hidden intent its why you should be careful who you choose. I'm not saying you shouldn't you should just be sure that you aren't going to end up with someone who is going to put malware in the project.

AlphaCraft9658 commented 6 months ago

Hi! I just wanted to mention that it seems like the qt6-branch is basically ready to merge? Quite a few people have successfully built Lightly-qt6, and they don't seem to have any issues.

AlphaCraft9658 commented 6 months ago

Any updates?

Manut38 commented 5 months ago

I just wanted to drop in and inform, that under KDE neon I needed to figure out these additional dev dependencies in order for the cmake -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_INSTALL_LIBDIR=lib -DBUILD_TESTING=OFF .. within the /build dir to succeed:

sudo apt install kf6-kcoreaddons-dev kf6-kcolorscheme-dev kf6-kguiaddons-dev kf6-kiconthemes-dev kf6-kconfig-dev kf6-ki18n-dev kf6-kwindowsystem-dev kf6-kirigami-dev kf6-kcmutils-dev

I also needed to follow these instructions posted earlier:

Switched to qt6 branch, added lightlystyleconfig.json to /kstyle/config and pulled CMakeLists.txt, kcm_lightlydecoration.{json,cpp} from the config.tar.gz to kdecoration/config

And I ran into this same following issue:

My problem while compiling this was that config/ui_lightlyconfigurationui.h was not being generated. So I cd'd into /build/kdecoration/config/ i executed make and it generated the ui_lightlyconfigurationui.h

I needed to execute these steps after trying to run the cmake command one time.

After this, running make in /build succeeds and the installation with sudo make install also runs fine.

So far everything looks great, as far as I can tell I'm not missing anything from Qt5. Thanks a bunch to everybody involved!

AlphaCraft9658 commented 5 months ago

Any progress? It does seem that even more people have figured it out. It would be great if we could see a full release soon, as that's one of the things keeping me from upgrading to KDE Plasma 6 just yet. Aside from the NVIDIA driver and Latte Dock, which should also soon be updated.

OzzyHelix commented 5 months ago

Any progress? It does seem that even more people have figured it out. It would be great if we could see a full release soon, as that's one of the things keeping me from upgrading to KDE Plasma 6 just yet. Aside from the NVIDIA driver and Latte Dock, which should also soon be updated.

I am actively tracking the porting of Latte Dock to Plasma 6 I test the commits every time I see a new one and they have it building at about 50% right now https://invent.kde.org/plasma/latte-dock/-/issues/134

OzzyHelix commented 5 months ago

correction I just tested the latest commit latte dock builds to 81% so a port might be done sooner than I thought

AlphaCraft9658 commented 5 months ago

Any progress? It does seem that even more people have figured it out. It would be great if we could see a full release soon, as that's one of the things keeping me from upgrading to KDE Plasma 6 just yet. Aside from the NVIDIA driver and Latte Dock, which should also soon be updated.

It's a bit concerning that this issue is being this silent and that there are no commits or anything. Is everything alright, @boehs?

AlphaCraft9658 commented 4 months ago

Is anything happening here?

AlphaCraft9658 commented 4 months ago

Hi, Lightly now works on my KDE Neon but I have some display bugs: Copie d'écran_20240325_221052

Not reproducible in Fedora

Screenshot_20240328_192542

How did you manage to compile? I want to maybe self-compile until there is a stable release, as I really want to upgrade to Plasma 6.

hazel-bunny commented 4 months ago

How did you manage to compile?

I package it for Fedora 40 and above in my copr using a patch from the AUR. You can enable my copr and install it from there if you're on Fedora. The spec file is available on GitHub.

AlphaCraft9658 commented 4 months ago

How did you manage to compile?

I package it for Fedora 40 and above in my copr using a patch from the AUR. You can enable my copr and install it from there if you're on Fedora. The spec file is available on GitHub.

I'll probably try that out then. Thanks!

OzzyHelix commented 3 months ago

there seems to be a problem with it I can't seem to open the settings for Lightly on this fork image

AlphaCraft9658 commented 1 week ago

Any updates? It looks basically ready, but has no official release. I can use that one copr repo for now, but an official release would be great. There also appear to be some issues opening the settings. @boehs

OzzyHelix commented 1 week ago

this fork builds but the settings page doesn't work and we need an update on that and if the settings page will get fixed I am citing issue #36

boehs commented 1 week ago

I'm sorry to announce that I believe this fork must be essentially deprecated, my Linux machine has been broken for months by now and VMs run very poorly on the new macOS machine. With the building issues people have had, I cannot in good conscious merge the PR code without having built it myself, and I certainly won't be able to fix that settings issue.

I see that @xuzhao9 has opened a number of pull requests to the main lightly repository. He may be interested in maintaining his own repository, or one of you may. For security, I will not officially endorse any forks, but I want to leave the repository unarchived for the next few months to discuss who, if anybody, will be next, somebody who I'm sure will do a much better job than I did. If consensus does emerge, I will amend the repository's README to make note of that. I just don't think its fair to any one of you for me to be at the reigns, paralyzed. I hope that by stepping aside a new leader can emerge.

Regardless of what happens, I'm happy that hundreds of you were able to extend the lifetime of this theme by a number of months. Peace ❤️

OzzyHelix commented 1 week ago

I think you should approach @xuzhao9 about continuing your work

boehs commented 1 week ago

I don’t think it’s appropriate to thrust such responsibility upon him, all I was stating is that he’s been doing his own work. If he wishes to step up to bat, he’s free to, but I don’t want to force or pressure anybody into it, and again, I won’t be officially endorsing anything. He was mentioned, if he wants he can comment, and if he doesn’t, please leave him alone :)

OzzyHelix commented 1 week ago

I did just compile his zx9/kde6 branch and it works on Plasma 6.2 so I guess take that as you will he may already have the stuff needed to switch over

OzzyHelix commented 1 week ago

I also tested their master branch and it builds on Plasma 6.2 and the zx9/kde6 branch doesn't have transparency working fully but the main branch builds and installs

OzzyHelix commented 1 week ago

they have also expanded Lightly into a global theme it seems

xuzhao9 commented 1 week ago

Hi all, yes I am happy to continue the development at https://github.com/xuzhao9/Lightly. I am also using this theme on my Linux desktop personally.

There are a few GTK theme bugs we need to fix, but overall I am happy with it and I only plan to keep KDE compatibility upgrade and bugfix. I am glad to review any patches that add enhancement, too.

@OzzyHelix can you help test on https://github.com/xuzhao9/Lightly to check if the transparency has been fixed?

OzzyHelix commented 1 week ago

Hi all, yes I am happy to continue the development at https://github.com/xuzhao9/Lightly. I am also using this theme on my Linux desktop personally.

There are a few GTK theme bugs we need to fix, but overall I am happy with it and I only plan to keep KDE compatibility upgrade and bugfix. I am glad to review any patches that add enhancement, too.

@OzzyHelix can you help test on https://github.com/xuzhao9/Lightly to check if the transparency has been fixed?

the problem I encoutered was with the zx9/kde6 branch when I built the master branch it worked just fine

OzzyHelix commented 1 week ago

the master branch seems to be more updated than the zx9/kde6 branch the thing is there is someone who will probably want to build Lightly with kf5 support for qt5 apps on the AUR so we need to support both kf5 and kf6

OzzyHelix commented 1 week ago

@xuzhao9 I would get in contact with the AUR package maintainer and notify them that you are taking over for boehs. https://aur.archlinux.org/packages/lightly-kf6-git

OzzyHelix commented 1 week ago

that way your version of Lightly can be pushed to the AUR and the chaotic aur