Added Nginx 1.8.0 version - Githubissues

boekkooi / openshift-cartridge-nginx

43 stars 36 forks source link

Added Nginx 1.8.0 version #5

Closed vs0uz4 closed 8 years ago

vs0uz4 commented 9 years ago

Added nginx 1.8.0 version;
Change manifest.yml;
Added 1.8.0 version in versions files;
Change README.md for example with nginx 1.8.0.

boekkooi commented 9 years ago

@vs0uz4 Wow looks like a great PR!

Just one request could you merge the first 4 commits (https://github.com/vs0uz4/openshift-cartridge-nginx/commit/8deeca63c6f8a7d67348b445a663ab32c5510142 https://github.com/vs0uz4/openshift-cartridge-nginx/commit/1802d228daa825074bf57d934ce9e713a5e208df https://github.com/vs0uz4/openshift-cartridge-nginx/commit/1940c2646d334ae94fdc7ea76153e011177c085c and https://github.com/vs0uz4/openshift-cartridge-nginx/commit/f47cd8e5d0db68a38f8d556442ecf0e81082847f) into one?

I will give this a test run in the next couple of days.

Thanks again!

vs0uz4 commented 8 years ago

@boekkooi Sorry about the delay, I was busy. See now is as you requested.

boekkooi commented 8 years ago

Great thank you very much