search

boeledi / RangeSlider

RangeSlider Widget for Flutter
Other
374 stars 67 forks source link

Slider layout not behaving like the default Slider() #11

Closed MrWaggel closed 5 years ago

MrWaggel commented 5 years ago

Problem: When you put a RangeSlider() underneath a default Slider(), the width doesn't match. before

Possible solution In class file, change line 520 static const double _overlayDiameter = _overlayRadius * 2.0; static const double _overlayDiameter = _overlayRadius;

and at line 733 under the void performResize() {} method to preserve the correct height constraints.hasBoundedHeight ? constraints.maxHeight : _overlayDiameter, constraints.hasBoundedHeight ? constraints.maxHeight : _overlayDiameter * 2, after

But I'm not sure if it creates the wanted behavior for other cases, if you want I'll generate a pull request.

Awesome library and great documentation by the way my Wallonian friend, much appreciated! Greetings from the north

boeledi commented 5 years ago

Hi, I just released version 1.1.0 which now integrates your changes. Thanks for your contribution.