boermansjo / ESX_HUD

Default starting project with Enhanced HUD
GNU General Public License v3.0
48 stars 39 forks source link

Vanilla skinchanger still showing up #8

Closed Dexterin0 closed 4 years ago

Dexterin0 commented 4 years ago

Pretty new to this LUA and GTA scripting, slowly getting the hang of it. Had this UI parked now, tried yours and I cant seem to get it working as it always calls the vanilla esx skin changer, although I removed esx_skin and skinchanger from the server.cfg. This is due to its roots in the vanilla esx menu I guess.

Isn't there something missing to call this skinchanger instead of the vanilla ui or am I missing something?

boermansjo commented 4 years ago

Hi, You still need skinchanger. My script only replace esx_skin. This is still in production. Not ready for a public server. But for a Dev it can be fun. If the menu is still showing, make sure the cache is deleted. (You can also check the console when the server is loading. If you see any esx_skin some other script may have this in his dependency) I also noticed a small error. I will fix that this evening.

If the esx_skin is still loading, are you using the esx clotheshop ? If you do, you will need to change the _resource of esx_clotheshop : dependencies { 'es_extended', 'esx_skin' } into dependencies { 'es_extended' }

Dexterin0 commented 4 years ago

I stopped esx_skin through the console and could open the new hud with the command then, when I tried to join esx_jobs couldn't load anymore. Im getting closer. haha

Currently doing some try and error, somehow it loaded esx_skin even if I took it out of the server.cfg and out of the cache lol. I removed the folder for now and as Im using the clothingshop I will change that line now.

Thanks!

Dexterin0 commented 4 years ago

Removed esx_skin from esx_jobs and esx_barbershop as well.

boermansjo commented 4 years ago

If this gives to many problems, I will rename the resource into esx_skin. Then we don't have to change all the dependencies. Those lines are a curse for when you want to make a new script :D Best way you can do is remove the esx_skin folder and run the server. All scripts who uses dependencies will fail 😄 Edit : I fixed the small error. This was needed to get the saved skin back.

Dexterin0 commented 4 years ago

Actually thats fine, could have realized that myself its called elsewhere. I had some more with it inside, so for a final release changing the ressource name might be a good idea.

Got it cleared out now, now more vanilla esx_skin. :P Running the command now works fine, opening the menu when first spawned is not included yet or do I have to change the one line from the other issue?

boermansjo commented 4 years ago

It is included. I test this with esx_identity. There is a line like this : TriggerEvent('esx_skin:openSaveableMenu', myIdentifiers.id) So I don't know what you use to create the name and stuff. (You may not use any...) For the record, this version still has the vanilla esx_skin menu. This is so that your barbershop or jobs still works.

Dexterin0 commented 4 years ago

Got it working thanks. :)

Yes thats the good thing! Thats why I took yours, to keep functionality.

Good work.

boermansjo commented 4 years ago

Nice. You will experience some crazy stuff for now. It will look like you have 2 skins when you use the clotheshop. Still debugging this.

Dexterin0 commented 4 years ago

Haha okay, if I see something I'll write it down and see what I can do as well.

But with my vanilla esx_skin this happened as well....that and the look of the ui were the reason I wanted to get rid of it.

kydsvandy commented 4 years ago

So I change my esx_identity TriggerEvent('hud:loadMenu') to TriggerEvent('esx_skin:openSaveableMenu', myIdentifiers.id) now it opens the default skincreator when you /register Screenshot (951)

boermansjo commented 4 years ago

You probably still have esx_skin that is loading. Make sure all dependencies are changed. If one still has esx_skin in it, it will be loaded. You can check the console to see if it is loaded or not.

kydsvandy commented 4 years ago

I stop my esx_skin.. but still showing

boermansjo commented 4 years ago

That is the problem. Stopping the script is not enough. If you have any other script that was using that it will load esx_skin. (Even if you didn't include it in the server.cfg) You probably have an other script (like esx_clotheshop) where you have a dependency. Dependencies will load the script if it is in the resource folder. So best way to find out is to remove the esx_skin folder and run your server. Don't forget to clear the cache also.

kydsvandy commented 4 years ago

oh yeah esx_jobs still use esx_skin maybe that's why?

kydsvandy commented 4 years ago

but now everytime I join I have an npc skin for some reason..

kydsvandy commented 4 years ago

yep changing the dependencie of esx_jobs from esx_skin to skincreator.. make you spawn as npc everytime you join the server.

Dexterin0 commented 4 years ago

Make sure to keep skinchanger, remove esx_skin, search via notepad for all esx_skin dependencies, remove them, optional delete the outfit tables in your database and you should be good to go, for me it worked and I have lots of smaller changes in esx and lots of additions.

kydsvandy commented 4 years ago

Make sure to keep skinchanger, remove esx_skin, search via notepad for all esx_skin dependencies, remove them, optional delete the outfit tables in your database and you should be good to go, for me it worked and I have lots of smaller changes in esx and lots of additions.

but removing esx_skin on the dependecies of esx_jobs make every player invisible everytime they join the server.

blurryrox commented 4 years ago

I am just guessing here but maybe it has issues after removing the esx_skin folder because of this? server/main.lua : Line 22 local file = io.open('resources/[esx]/esx_skin/skins.txt', "a")

ighorplays commented 4 years ago

hello, I'm using this script on my server for the community, but I face a problem that I'm finding a bag, without esx_skin in the work they don’t put on their uniforms / take the burden out of the work, sorry my English from the translator, would you have any idea to solve this problem?

EnerGonix commented 4 years ago

I get it to work but im using esx_np_skinshop v2 and the skin goes back to the default one when i go to a cloth shop!

Can someone help ?

Squad3tm commented 4 years ago

Might help people, if you're using another character creator, make sure you uncomment "onFirstSpawn" in esx_skin to prevent the default skin creator popping up.

boermansjo commented 4 years ago

If you are using my version, you don't need this. I replace that function. All you have to do was remove the esx_skin folder. But they made some changes in the recent version. Not sure if want to spend time in fixing all this if FiveM keeps blacklisting ESX...

Squad3tm commented 4 years ago

If you are using my version, you don't need this. I replace that function. All you have to do was remove the esx_skin folder. But they made some changes in the recent version. Not sure if want to spend time in fixing all this if FiveM keeps blacklisting ESX...

Oh, sorry, I didn't realise it was fixed. Just thought it would be a good input!

boermansjo commented 4 years ago

Yes it is still a good input. Most people are trying to add this and keep esx_skin also... This will not work. The original script was kind of a mess mixing both scripts. I never spend much time in making it a stand-alone version. If someone wants to try, I can always help.

boermansjo commented 4 years ago

I removed the complete old esx_skin menu. This version now only do the creation part. Using it may break something

moquino commented 3 years ago

iam using skincreator but when i join i found the default skin menu and skincreator menu, now i want use skincreator only in FirstSpwan and esx_skin for clothes shop, how to do that ?

note:

domysalv commented 3 years ago

@moquino could you solve this? @boermansjo any way to do this?

Codyshep commented 2 years ago

my menu wont save/close