search

boettiger-lab / earthdatalogin

Making public access of public data a bit easier
https://boettiger-lab.github.io/earthdatalogin/
Other
22 stars 4 forks source link

Implement `collections_fetch()` #11

Closed ateucher closed 2 months ago

ateucher commented 2 months ago

Closes #10, but rather than a wrapper, implements our version of collections_fetch(). This would ideally live in rstac, but this implementation is useable now.

Issue open in rstac to add it there (though the implementation would be different in rstac as we could leverage internal methods)

ateucher commented 2 months ago

Note: I've also exported edl_stac_urls() (#9), which I think is a handy function to have available to users.

ateucher commented 2 months ago

@cboettig some failures related to auth, but it looks like the EARTHDATA_USE and EARTHDATA_PASSWORD are set?

cboettig commented 2 months ago

yeah the auth issue looks surprising, I need to take a look. maybe is related to secrets but I thought I had public credentials for this in place. no errors locally?

cboettig commented 2 months ago

ah looks like I used encrypted secrets, and GitHub says:

Anyone with collaborator access to this repository can use these secrets and variables for actions. They are not passed to workflows that are triggered by a pull request from a fork.

so should be fine once merged.

ateucher commented 2 months ago

yeah the auth issue looks surprising, I need to take a look. maybe is related to secrets but I thought I had public credentials for this in place. no errors locally?

Yup, everything passed fine locally