bofh19 / yappi

Automatically exported from code.google.com/p/yappi
MIT License
0 stars 0 forks source link

error: sorttype param for get_stats is out of bounds #22

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Using 0.53, if I supply no parameters to get_stats() or I supply 
yappi.SORTTYPE_TTOTAL, I get this exception:

error: sorttype param for get_stats is out of bounds

I am using python 2.6 on OS X 10.6.7

Original issue reported on code.google.com by devin.ba...@gmail.com on 30 Mar 2011 at 8:36

GoogleCodeExporter commented 9 years ago
Interesting. Can you provide the following command output from your console:

> import yappi
> print yappi.SORTTYPE_TTOTAL
2

Original comment by oktaka...@gmail.com on 12 Apr 2011 at 6:43

GoogleCodeExporter commented 9 years ago
>>> import yappi
>>> yappi.SORTTYPE_TTOTAL
2

Original comment by devin.ba...@gmail.com on 12 Apr 2011 at 7:52

GoogleCodeExporter commented 9 years ago
The problem is a comparison problem between and signed/unsigned value pair. I 
don't have a test setup for OSx, can you please copy the attached file to your 
setup dir. and verify it works or not?

Original comment by oktaka...@gmail.com on 12 Apr 2011 at 11:21

Attachments:

GoogleCodeExporter commented 9 years ago
It does seem to work. Thanks!

Original comment by devin.ba...@gmail.com on 12 Apr 2011 at 12:20

GoogleCodeExporter commented 9 years ago
Can you please verify the sorting works when you change the sorttype to other 
types? 

yappi.get_stats(sorttype=yappi.SORTTYPE_TTOTAL)
yappi.get_stats(sorttype=yappi.SORTTYPE_NCALL)
yappi.get_stats(sorttype=yappi.SORTTYPE_TSUB)

Functionality works?

Original comment by oktaka...@gmail.com on 12 Apr 2011 at 12:43

GoogleCodeExporter commented 9 years ago
The sorting is proper in all cases and defaults to NCALL

Original comment by devin.ba...@gmail.com on 12 Apr 2011 at 1:05

GoogleCodeExporter commented 9 years ago
Thanks!

Original comment by oktaka...@gmail.com on 12 Apr 2011 at 1:11

GoogleCodeExporter commented 9 years ago
Hi folks, I tried the attached _yappi.c file: exception is gone but sorting 
doesn't seem to work (results are returned unsorted):

name                                 #n       tsub       ttot       tavg
..imple_httpclient.py._on_connect:16 1        0.000066   0.000392   0.000392   
../logging/__init__.py.getMessage:28 1        0.000003   0.000004   0.000004   
../python2.6/threading.py.release:13 1        0.000005   0.000007   0.000007   
..n2.6/threading.py.currentThread:80 1        0.000003   0.000003   0.000003   
..ple_httpclient.py._process_queue:9 2        0.000024   0.000721   0.000360   
..async_orm/chains.py.__getstate__:9 1        0.000005   0.000009   0.000009   
..utils/datastructures.py.getlist:30 1        0.000011   0.000012   0.000012   
../python2.6/posixpath.py.normcase:4 2        0.000001   0.000001   0.000000   
..tornado/tornado/httputil.py.get:12 2        0.000004   0.000011   0.000005   
...6/logging/__init__.py.warning:105 1        0.000008   0.000211   0.000211   
..rm/async_orm/chains.py._pickled:10 1        0.000006   0.000090   0.000090   
..python2.6/contextlib.py.__exit__:2 5        0.000036   0.000291   0.000058   
..ado/tornado/iostream.py.connect:10 1        0.000021   0.000274   0.000274   
..ornado/stack_context.py.__init__:6 4        0.000004   0.000004   0.000001   
..lresolvers.py._get_reverse_dict:22 1        0.000001   0.000001   0.000001   
..gging/__init__.py.callHandlers:120 1        0.000009   0.000094   0.000094   
..on2.6/logging/__init__.py.flush:75 1        0.000005   0.000007   0.000007   
..rnado/iostream.py._handle_write:33 2        0.000022   0.000345   0.000172   
..nado/tornado/ioloop.py.register:46 6        0.000017   0.000133   0.000022   
..n2.6/site-packages/yappi.py.stop:4 1        0.000000   0.000000   0.000000   
..rnado/stack_context.py.__exit__:13 9        0.000011   0.000011   0.000001   
..nations/http/__init__.py.execute:3 1        0.000021   0.001110   0.001110   
..ado/tornado/iostream.py.writing:18 4        0.000009   0.000009   0.000002   
..ython2.6/threading.py.setprofile:8 1        0.000001   0.000001   0.000001   
..imple_httpclient.py._on_headers:24 1        0.000039   0.000974   0.000974  

Original comment by kmik...@gmail.com on 27 Apr 2011 at 9:40

GoogleCodeExporter commented 9 years ago
Hi,

You are running on OSX too?

Original comment by sum...@gmail.com on 28 Apr 2011 at 6:44

GoogleCodeExporter commented 9 years ago
I have made a new commit for this issue, I think it resolves all the problems 
related to it. https://bitbucket.org/sumerc/yappi/changeset/d59ff95f8088. Can 
you verify it works?

Original comment by sum...@gmail.com on 28 Apr 2011 at 7:03

GoogleCodeExporter commented 9 years ago
Yes, I'm running OSX 10.6.7 and python 2.6 (from macports). 

Version from bitbucket works: sorting is correct and exceptions are gone. 

Thank you for yappi, that's a great piece of code!

Original comment by kmik...@gmail.com on 28 Apr 2011 at 11:55

GoogleCodeExporter commented 9 years ago
Thanks!

Original comment by sum...@gmail.com on 29 Apr 2011 at 5:49

GoogleCodeExporter commented 9 years ago
Hi, 
Thank you for the fix it worked well. But when I tried to compile for python2.5 
it complained about a missing library bytesobject.h. Could you back port the 
fix for 2.5 ?

Thank you

Original comment by aurelien...@gmail.com on 27 May 2011 at 11:06

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
OK. But that's another compilation issue. (we have Missing PY3K check). Check  
Issue #24  or get the latest head from the hg rep.

Thanks,

Original comment by sum...@gmail.com on 30 May 2011 at 8:46

GoogleCodeExporter commented 9 years ago
All fixed in 0.54. 

Original comment by sum...@gmail.com on 15 Aug 2011 at 5:13